[D7] Parameter Message

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxrenatog2838641git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Issue tested.

1: Please sanitize data values before display in front-end. If we pass some script as data in admin/config/user-interface/parameter_message , its getting execute

  foreach ($messages_settings as $message_settings) {

    $message = explode('|', $message_settings);

    $parameter       = $message[0];
    $text_message    = $message[1];
    $type            = $message[2];

    $parameter_data  = explode('=', $parameter);

    $parameter_key   = $parameter_data[0];
    $parameter_value = $parameter_data[1];

    if (!empty($_GET[$parameter_key]) && $_GET[$parameter_key] == $parameter_value) {
      drupal_set_message($text_message, $type);
    }
  }

Please see the attach screenshot

2: Please use hook_uninstall to removing used variable instead of hook_install
Example :

/**
 * Implements hook_install().
 */
function parameter_message_install() {
  variable_del('parameter_message_messages');
}

3: Please update readme as https://www.drupal.org/node/2181737

Hello,

Here is my review:

Automated Review
No issues found when testing via pareview

https://pareview.sh/node/538

Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Thanks.

After a pair review with the author, @renatog, the issue was tested and its status is: OK.

The issue presented no issues after running PHPCS (Code Sniffer), please see attached screenshot "phpcs.png".

Below are the findings in manual review,
1) parameter_message_settings() function should have $form and &$form_state as parameters as it is a Drupal form.
2) In parameter_message_menu() function, remove 'access callback' => 'user_access',, as it is assumed as default by Drupal.
3) Please use hyphens instead of underscore in URL, correct menu path "admin/config/user-interface/parameter_message".

Please fix the above issues. And also,

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

I am postponing this issue for now. Please feel free to set this issue to RTBC, to proceed with single project promotion.

Thanks for your contribution, @renatog!

I have manually promoted this sandbox project to "full" project for you.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.