Hi!

Congrats on the module. He is excellent.

I added function t() for translate message and fixed variable unused.

Thanks.

Regards.

Patch with fix: personal_digest-translatevariable-2833778-2.patch

Img

Img

Img

CommentFileSizeAuthor
#2 personal_digest-translatevariable-2833778-2.patch1.4 KBrenatog
C.png49.55 KBrenatog
B.png60.26 KBrenatog
A.png58.49 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new personal_digest-translatevariable-2833778-2.patch1.4 KB

Patch submitted with the fixes.

Thanks.

Regards.

cebasqueira’s picture

cebasqueira commented
Status: Needs review » Reviewed & tested by the community

Code looks googd... RTBC

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs work

Hi!

Thanks for your patch.

One small nitpick:

-    drupal_set_message('Check your mail');
+    drupal_set_message(t('Check your mail'));

Here actually you can use $this->t instead the global function.

Regards.

matslats’s picture

matslats commented
Status: Needs work » Fixed
matslats’s picture

matslats commented
Status: Fixed » Closed (fixed)
renatog’s picture

renatog commented

Ok thanks guys @gnuget and @matslats.

Hugs.