Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements.

Thanks.

Img

Img

Img

Img

Img

Img

Img

Img

CommentFileSizeAuthor
#3 8) Img-33.png20.59 KBrenatog
#3 7) Img-33.png26.34 KBrenatog
#3 6) Img-33.png46.24 KBrenatog
#3 5) Img-33.png48.1 KBrenatog
#3 4) Img-33.png92.44 KBrenatog
#3 3) Img-33.png50.66 KBrenatog
#3 2) Img-33.png27.52 KBrenatog
#3 1) Img-33.png40.56 KBrenatog
#2 views_contact_form-codingstandards-2831804-2.patch9.59 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new views_contact_form-codingstandards-2831804-2.patch9.59 KB

Patch submitted with the fixes.

Thanks.

Regards.

renatog’s picture

renatog commented
Issue summary: View changes
StatusFileSize
new 1) Img-33.png40.56 KB
new 2) Img-33.png27.52 KB
new 3) Img-33.png50.66 KB
new 4) Img-33.png92.44 KB
new 5) Img-33.png48.1 KB
new 6) Img-33.png46.24 KB
new 7) Img-33.png26.34 KB
new 8) Img-33.png20.59 KB
gfcamilo’s picture

gfcamilo commented

Issue tested

gfcamilo’s picture

gfcamilo commented
Status: Needs review » Reviewed & tested by the community
renatog’s picture

renatog commented
Issue tags: +ciandt-contrib
balajidharma’s picture

balajidharma
Primary language English
commented
Category: Bug report » Task

  • balajidharma committed 8757bf7 on 7.x-1.x 
    Issue #2831804 by RenatoG, gfcamilo, balajidharma: Coding Standards
balajidharma’s picture

balajidharma
Primary language English
commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed
pol’s picture

pol
Location Brussels
commented

Dear balajidharma

Did you received my email? I sent it a couple of days ago.

Thanks!

balajidharma’s picture

balajidharma
Primary language English
commented

Hi Pol,

Yes, just now checked your email and replied.

Thanks,
Balaji

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.