Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements.

Thanks.

Img

Img

Img

Img

Img

Img

CommentFileSizeAuthor
#2 chosen-codingstandards-2831116-2.patch10.37 KBrenatog
1) Img.png29.3 KBrenatog
6) Img.png63.31 KBrenatog
5) Img.png21.35 KBrenatog
4) Img.png76.17 KBrenatog
3) Img.png19.04 KBrenatog
2) Img.png28.75 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new chosen-codingstandards-2831116-2.patch10.37 KB

Patch submitted with the fixes.

Thanks.

Regards.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Thanks! Committed.

renatog’s picture

renatog commented

You're welcome @nagy.balint.

I thank you.

Regards.

renatog’s picture

renatog commented
Issue tags: +ciandt-contrib

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.