Hi!

Just a few coding standards improvements.

Thanks.

Img

Img

Img

CommentFileSizeAuthor
#13 gplus_comments_block-codingstandards-2831741-13.patch3.73 KBrenatog
#12 gplus_comments_block-codingstandards-2831741-11.patch3.73 KBrenatog
#8 gplus_comments_block-codingstandards-2831741-8.patch3.72 KBrenatog
#4 3) Img-30.png20.1 KBrenatog
#4 2) Img-30.png16.7 KBrenatog
#2 gplus_comments_block-codingstandards-2831741-2.patch3.72 KBrenatog
3) Img-30.png19.07 KBrenatog
2) Img-30.png15.48 KBrenatog
1) Img-30.png114.6 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new gplus_comments_block-codingstandards-2831741-2.patch3.72 KB

Patch submitted with the fixes.

Thanks.

Regards.

  • renatog authored 799916f on 7.x-1.x 
    Issue #2831741 by renatog: Coding Standards
renatog’s picture

renatog commented
Issue summary: View changes
StatusFileSize
new 2) Img-30.png16.7 KB
new 3) Img-30.png20.1 KB
pol’s picture

pol
Location Brussels
commented
Status: Needs review » Fixed

Thanks!

  • 7d05999 committed on 7.x-1.x 
    Revert "Issue #2831741 by renatog: Coding Standards"

This reverts...
pol’s picture

pol
Location Brussels
commented
Status: Fixed » Needs work

I was too hasty. Looks like there are some inconsistencies in your patch. Reverting it.

renatog’s picture

renatog commented
Status: Needs work » Needs review
StatusFileSize
new gplus_comments_block-codingstandards-2831741-8.patch3.72 KB

Sorry @pol.

I checked it.

New patch with fix follow in attachment.

Regards.

gfcamilo’s picture

gfcamilo commented
Status: Needs review » Reviewed & tested by the community

Issue tested

renatog’s picture

renatog commented
Issue tags: +ciandt-contrib
pol’s picture

pol
Location Brussels
commented
Status: Reviewed & tested by the community » Needs work

There are still inconsistencies.

renatog’s picture

renatog commented
StatusFileSize
new gplus_comments_block-codingstandards-2831741-11.patch3.73 KB

Hi @Pol.

You're right.

In attachment the new patch with the fix.

Thanks.

Regards.

renatog’s picture

renatog commented
Status: Needs work » Needs review
StatusFileSize
new gplus_comments_block-codingstandards-2831741-13.patch3.73 KB
pol’s picture

pol
Location Brussels
commented
Status: Needs review » Fixed

Thanks!

  • Pol committed 8c1c443 on 7.x-1.x authored by renatog 
    Issue #2831741 by renatog: Coding Standards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.