Hi!

Congrats on the module. The group of scald modules is excellent.

Just a few coding standards improvements in files of root folder:

README.txt
scald-atom.tpl.php
scald.api.php
scald.features.inc
scald.info
scald.install
scald.module
scald.tokens.inc

Img

Thanks.

Img

Img

Img

Img

Img

Img

Img

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

renatog created an issue. See original summary.

renatog’s picture

Patch submitted with the fixes.

Thanks.

Regards.

renatog’s picture

Issue summary: View changes
FileSize
164.82 KB
renatog’s picture

Issue summary: View changes
FileSize
82.97 KB
16.37 KB
17.77 KB
86.56 KB
157.33 KB
renatog’s picture

gfcamilo’s picture

Status: Needs review » Reviewed & tested by the community

Issue tested.

renatog’s picture

Issue tags: +ciandt-contrib
nagy.balint’s picture

Status: Reviewed & tested by the community » Needs work

Thanks for the patch!

1. I was wondering why these
+ * Form.
strings are there under @@ -471,10 +516,14 @@ function hook_scald_atom_delete($atom) {
and @@ -492,10 +541,14 @@ function hook_scald_add_form(&$form, &$form_state) { and such

2. The text addition above scald_invoke_atom_access is wrong, cause that function only takes a single action as a string.
In scald_action_permitted where its called, there is a check, and if the action is an array then it is handled differently, if its not then that function is called with a single value.

renatog’s picture

Hi @nagy.balint.

I thank you for your points.

You are completely correct.

1) The Form is a description for param $form. But it was not very clear.

I fixed it in all places.

Img

2) In item 2; you're right too. The function only takes a single action as a string.

I fixed these items and new patch with fix is annexed.

Thank you very much @@nagy.balint.

Good weekend.

nagy.balint’s picture

Status: Needs review » Fixed

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.