Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements.

Thanks.

Img

Img

Img

Img

Img

CommentFileSizeAuthor
#2 addanother-codingstandards-2829933-2.patch10.75 KBrenatog
5) Img.png23.52 KBrenatog
4) Img.png40.61 KBrenatog
3) Img.png34.91 KBrenatog
2) Img.png65.03 KBrenatog
1) Img.png130.19 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new addanother-codingstandards-2829933-2.patch10.75 KB

Patch submitted with the fixes.

Thanks.

Regards.

cebasqueira’s picture

cebasqueira commented
Status: Needs review » Reviewed & tested by the community

+RTBC

renatog’s picture

renatog commented
Issue tags: +ciandt-contrib

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.