Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements for Drupal 8.

Thanks.

CommentFileSizeAuthor
#7 eu_cookie_compliance-drupal-8-coding-standards-2833726-7.patch15.88 KBsvenryen
#3 interdiff-2833726-2-3.txt326 bytescebasqueira
#3 drupal_8_coding_standards-2833726-3.patch13.82 KBcebasqueira
#2 eu_cookie_compliance-codingstandards-2833726-2.patch13.39 KBrenatog
Result.txt7.53 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new eu_cookie_compliance-codingstandards-2833726-2.patch13.39 KB

Patch submitted with the fixes.

Thanks.

Regards.

cebasqueira’s picture

cebasqueira commented
StatusFileSize
new drupal_8_coding_standards-2833726-3.patch13.82 KB
new interdiff-2833726-2-3.txt326 bytes

Small fix on patch!

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Thanks @cebasqueira.

Regards.

killua99’s picture

killua99 commented

I'll check this, looks good for now.

renatog’s picture

renatog commented

Ok @killua99. Thank you very much.

Regards.

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-drupal-8-coding-standards-2833726-7.patch15.88 KB

I added a few more Drupal 8 standard fixes and rerolled the changes to css, as those were fixed already. Here's an improved patch.

  • svenryen committed 3b01cf6 on 8.x-1.x authored by RenatoG 
    Issue #2833726 by RenatoG, cebasqueira, svenryen: Drupal 8 Coding...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed
svenryen’s picture

svenryen commented
Status: Fixed » Closed (fixed)