Hi!

Just a few coding standards improvements.

Patch with the fixes: block_export_import-codingstandards-2834764-4.patch

Thanks.

Img

Img

CommentFileSizeAuthor
#4 block_export_import-codingstandards-2834764-4.patch5.69 KBrenatog
#2 B) 34.png104.36 KBrenatog
#2 A) 34.png51.32 KBrenatog
#2 block_export_import-codingstandards-2834764-2.patch5.69 KBrenatog
B) 34.png99.27 KBrenatog
A) 34.png48.75 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new block_export_import-codingstandards-2834764-2.patch5.69 KB
new A) 34.png51.32 KB
new B) 34.png104.36 KB

Patch submitted with the fixes.

Thanks.

Regards.

Status: Needs review » Needs work

The last submitted patch, 2: block_export_import-codingstandards-2834764-2.patch, failed testing.

renatog’s picture

renatog commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new block_export_import-codingstandards-2834764-4.patch5.69 KB
gmaltoni’s picture

gmaltoni commented
Assigned: Unassigned » gmaltoni
gmaltoni’s picture

gmaltoni commented
Status: Needs review » Reviewed & tested by the community

I applied the patch and it worked cleanly.

gmaltoni’s picture

gmaltoni commented

I applied the patch and it worked cleanly.

gmaltoni’s picture

gmaltoni commented
Assigned: gmaltoni » Unassigned

  • devd committed bc29847 on 7.x-2.x authored by RenatoG 
    Issue #2834764 by RenatoG, ashleywilson: Coding Standards

devd credited ashleywilson.

devd’s picture

devd commented
Status: Reviewed & tested by the community » Fixed
devd’s picture

devd commented
Version: 7.x-2.x-dev » 7.x-2.34
Status: Fixed » Closed (fixed)