Attached patch fixes coding standard issues.

CommentFileSizeAuthor
#9 metatag-n2826023-9.patch17.56 KBrenatog
#7 metatag-n2826023-7.patch14.43 KBdamienmckenna
#7 metatag-n2826023-7.interdiff.txt624 bytesdamienmckenna
#5 fix_coding_standards-2826023-5.patch14.38 KBgfcamilo
fix_coding_standards_metatag_0.patch5.7 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Status: Needs work » Needs review
gfcamilo’s picture

gfcamilo commented

Issue tested.

renatog’s picture

renatog commented

Ok @gfcamilo.
Thanks.

gfcamilo’s picture

gfcamilo commented
StatusFileSize
new fix_coding_standards-2826023-5.patch14.38 KB

Hi,

I supplemented the code fix.

Status: Needs review » Needs work

The last submitted patch, 5: fix_coding_standards-2826023-5.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2826023-7.interdiff.txt624 bytes
new metatag-n2826023-7.patch14.43 KB

This is great, thank you both for working on the improvements.

One change I'd request is the description of metatag_entity_get_language() should be rewritten, the way you've written it the second sentence is incomplete, maybe something like this would be better.

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Status: Needs review » Active
renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new metatag-n2826023-9.patch17.56 KB

Hi @DamienMcKenna!

I did the review and it's ok for me. Thanks.

I added some fixes of improvements in metatag.module file.

Things of PHP Code Sniffer (phpcs), like: "There must be no blank line following an inline comment" or "Inline comments must end in full-stops, exclamation marks, or question marks".

The patch with fix follow in attachment.

Thanks guys.

Antonio W. Mucciolo Jr.’s picture

Antonio W. Mucciolo Jr. commented
Status: Needs review » Reviewed & tested by the community

+RTBC

larruda’s picture

larruda commented

Maintainer just notified by email.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thank you, but I do get email notifications of issue updates, so there was no need to contact me directly.

I'll get to this soon.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2758749: Plan for Metatag 7.x-1.18 release

Committed. Thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.