Closed (outdated)
Project:
Field collection
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2016 at 18:20 UTC
Updated:
21 Oct 2019 at 07:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
renatog commentedPatch submitted with the fixes.
Thanks.
Regards.
Comment #3
renatog commentedComment #4
cebasqueira commentedRTBC
Comment #5
jmuzz commentedI like where this is going but there's a few issues.
Can we leave these out? They aren't in core and most of the popular contrib modules don't have them. I saw them in the date module but they weren't used like this.
I don't understand why they would be needed for the object properties or the short object method declarations.
For the long function declarations I am in favour of splitting them to multiple lines but that may not satisfy the analysing script or actual coding standards. Example:
Comments referring to functions should use the same casing as the function definition.
It is a #pre_render callback.
I'd change it to "Field collection tests." probably.
The one liners should state what the function does, not what it is. For example "Gets the Info".
The way the standards document explains it is: For most functions [...] summary lines must start with a third person singular present tense verb, and they must explain what the function does. Example: "Calculates the maximum weight for a list."
There are actually a lot of other small violations of this such as not using third person like "Test something" when it should be "Tests something" and I'd still commit this with them in it. Could open up a followup issue for that rule specifically.
Not sure you meant to put the @charset on the same line as other stuff. It should have its own line.
Comment #7
danilo_formagio commentedComment #8
ram4nd commented