Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements.

Thanks.

CommentFileSizeAuthor
#4 2833391-4--coding_standards.patch7.47 KBdrunken monkey
#4 2833391-4--coding_standards--interdiff.txt3.72 KBdrunken monkey
#3 screenshot-www.drupal.org-2016-12-06-16-47-33.png27.54 KBcebasqueira
#2 views_save-codingstandards-2833391-2.patch7.98 KBrenatog
Fixes.txt3.98 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Assigned: renatog » Unassigned
Status: Active » Needs review
FileSize
views_save-codingstandards-2833391-2.patch7.98 KB

Patch submitted with the fixes.

Thanks.

Regards.

cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
screenshot-www.drupal.org-2016-12-06-16-47-33.png27.54 KB

RTBC

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2833391-4--coding_standards--interdiff.txt3.72 KB
2833391-4--coding_standards.patch7.47 KB

Thanks a lot for the patch! I'm always keen to improve the adherance to coding standards in my projects.
However, I don't agree with all your changes. Please review my suggested update!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Fixed

Committed.
Thanks again!

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Hi @drunken-monkey! How are you?

I looked at the patch and I agree with your suggestions. Congrats, it's great.

Thank you very much.

Good work =)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.