Hi!

Just a few coding standards improvements.

Thanks.

msg91-codingstandards-2832487-2.patch

CommentFileSizeAuthor
#12 2832487-12.patch4.08 KBpk188
#3 smsmsg91.module.txt14.59 KBrenatog
#3 README.txt522 bytesrenatog
#3 smsmsg91.admin_.inc_.txt5.06 KBrenatog
#3 smsmsg91.info.txt365 bytesrenatog
#2 msg91-codingstandards-2832487-2.patch9.35 KBrenatog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Assigned: renatog » Unassigned
Status: Active » Needs review
FileSize
msg91-codingstandards-2832487-2.patch9.35 KB

Patch submitted with the fixes.

Thanks.

Regards.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Issue summary: View changes
FileSize
smsmsg91.info.txt365 bytes
smsmsg91.admin_.inc_.txt5.06 KB
README.txt522 bytes
smsmsg91.module.txt14.59 KB
gfcamilo’s picture

gfcamilo CreditAttribution: gfcamilo at CI&T commented
Status: Needs review » Reviewed & tested by the community

Issue tested.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Assigned: Unassigned » gaurav.kapoor
Status: Reviewed & tested by the community » Needs review

I'd like to have a 2nd look. Assigning myself for review.Thanks.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented

Reviewed , applies cleanly. Thanks @renatoG and @gfcamilo.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Status: Needs review » Fixed
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Thank you very much @gauravkapoor.

Good Work.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Status: Closed (fixed) » Needs work
Issue tags: -#ciandt-contrib

Due to some changes coding standards have to be reviewed again.

pk188’s picture

pk188 CreditAttribution: pk188 at OpenSense Labs commented
Assigned: gaurav.kapoor » pk188
pk188’s picture

pk188 CreditAttribution: pk188 at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2832487-12.patch4.08 KB

Fixed!

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.