Problem/Motivation
Claro is aimed to be an experimental admin theme in Drupal 8.8.0 which according to Drupal development roadmap is aimed to be released on December 4, 2019. Drupal 8.8.0 feature freeze is on the week of October 14, 2019. Claro must reach at least beta status by then to be included in a stable release.
Claro stable criteria
Once the following level of feature completeness has been reached, we will consider tagging stable release for Claro:
- All core-gates are met
- Claro supports complex content authoring tasks including most prominent contrib modules (with more extensive validation that includes maintainers of contrib projects)
- Claro supports all Drupal core admin interfaces
- All global components supported by Seven have been designed and implemented
When alll that is done we can move to #3167121: Make Claro the default admin theme
Must-have issues for stable release:
Features
Done.
Accessibility
Done.
Usability improvements
Done.
Design improvements
Done.
Technical debt
Done.
Bugs
Done.
Performance
Done.
Completed
- #3067697: Dropbutton breaks when text is split to multiple lines
- #3123811: Grey text in Claro theme failed accessibility
- #3248239: Links in the tour tip body are visually the same as the rest of the text - Claro theme
- #3062751: Media and media library
- #3061042: Status Report Page Update
- #1936708: Current element values missing from vertical tabs when shown in 2-column layout
- #3066006: Convert Views UI to new design system
- #3072772: Initial Claro design for the modules page
- #3085212: Redesign maintenance page
- #3023311: Modal dialog style update
- #3057772: Ambiguous icons for collapsing/expanding menu items
- #3070493: Introduce a mechanism to provide an alternate Claro design for the toolbar in the future
- #3127466: Required fields are not identifiable on Internet Explorer 11 high contrast
- #3083657: Devise strategy to address several SVG loading+usage issues
- #3078524: Focus styling of WYSIWYG field inputs should be consistent with other inputs
- #3083570: Do not hide the label for the text format select input.
- #3158854: Node form: address chasm between main form and meta
- #3082685: Action links on admin/appearance
- #3082688: Excess space between details summary and details content does not match design.
- #3082691: Excess space on tables with action links and "show row weights" toggle. Does not match design.
- #3057577: Provide a way to add Buttons to Dropbutton
- #3024975: Add Drupal JavaScript theme function for checkbox
- #3067523: Add Drupal JavaScript theme functions for password confirm widget
- #3077938: Add a new Drupal.theme JavaScript function for tabledrag handle to allow themes customize the handle's markup
- #197641: Drag and drop is not RTL aware
- #3059847: Move hard coded AJAX progress bar classes to a theme function
- #3084579: Claro Core inclusion that removes the duplicate JS
- #3060697: Use dropbutton variants with #dropbutton_type instead of custom classes
- #3084810: Decouple Claro from Classy
- #3024996: Remove tableselect.js and media_library.view.js overrides
- #3084916: Add a new Drupal.theme JavaScript function for theming the the show/hide row weight toggle and its wrapper in draggable tables
- #3081191: Select elements do not fully display letters with descenders
- #3005403: Cannot delete or edit a block that is placed in a section of the layout_builder
- #3084724: Regression on table select checkbox
- #3056046: SVG Problem with AdvAgg aggregation
- #3156362: Add default block configuration to Claro
- #3085245: Un-inline SVGs in pcss.css files, add build tool to inline them when compiled
- #3194669: Misuse of explicit colour for active pager item in -ms-high-contrast media query
- #3154539: Implement new Gray scale on Claro
- #3083051: Refactor tabledrag when core issues are resolved
- #3177415: Vertical Tabs CSS classes applying to non-vertical tab detail element groups
- #3219921: Claro: display the vertical scrollbar when many results are returned by linkit
- #3130305: Ensure all of Claro's background images are visible in forced colors mode.
- #3269341: Claro <details> element not rendering properly in forced colors
- #3271305: Claro's radio buttons and checkboxes are unusable in high-contrast / forced colors mode
Should-have issues for stable release:
- #3068696: Tables overflow on mobile
- #3023322: Contextual Links Style Update
- #3020422: Toolbar style update
- #3029675: Add support for the inline variation of form elements
- #3083256: Create smaller variations for form elements
- #3072771: Color editor
- #3082672: Form prefix/suffix redesign in Claro
- #3072773: [PP-1 ]Image style edit page
- #3023325: Help Style Updates
- #3057281: Add js- prefixed classes for separation of JS functionality & CSS of Dropbutton element
- #3082694: Extra space between message and content when content has elements with margin-top
- #3080994: Spacing in Claro pushes content down, requiring much scrolling
- #3083003: Remove default no-screenshot image on appearance page
- #3068698: Better shortcut action link styles when there's limited horizontal space
- #3085794: Remove Firefox workaround for details focus effect
- #3127469: Form element error state not visible on Windows high contrast
- #3114910: Improve Claro styles for core compatibility details on available updates report
- #3057772: Ambiguous icons for collapsing/expanding menu items
- #3133639: Fix Claro styles for exposed views filters wrapped in fieldsets
- #3026421: Iconography
- #3266216: The section-titles in the preview section on views edit pages have a too low contrast
- #3266299: Claro: Form labels that are disabled have too low color contrast
- #3020418: Update Placeholder styles so that contrast ratio passes guidelines
- #3271652: The styling for optgroup labels in the time zone select list on the regional settings page isn't applied in all browsers
- #3272266: Grey button's background color has a too low contrast ratio against page background
- #3273056: Active and hover state of skip to main content has a too low color contrast
Could-have issues for stable release:
- #3070558: Implement bulk operation designs
- #3048785: IE focuses elements on click that should not be focusable, and Claro makes this very apparent.
- #3072660: Allow white transparent pngs to be seen in image-preview
- #3036742: CTA - Call to action component
- #3076820: [META] Layout redesign
- #2958478: Toolbar height calculation is faulty in multiple cases
- #3056089: Provide a new render element for accordion
- #3051605: Create new template for rendering Views UI tabs.
- #3053707: Views pager arrows should be easier to override in themes.
- #3084388: Document for theme regions in claro as compared to seven's
- #3084712: Improve content table design
- #3067273: Provide form for customizable settings
- #3045797: Use fluid typography in Claro
- #3025911: Quick Edit Style Update
- #3072770: Available updates page
- #3033852: Redesign range input
- #3045467: Allow overriding module CSS without overriding their toolbar styles
- #3053449: Style removal button for multi-value field widget items
- #3155531: Naming convention of color shades in the Drupal Design System (e.g. for Claro)
- #3222995: Implement chips based autocomplete designs
Post-stable
- #3085219: Installer is not very usable in Claro
- #3084814: Deprecate Seven theme
- #3084816: Determine how to deprecate themes
- #3084820: [meta] Update documentation screenshots to use Claro instead of Seven
- #3083176: Make sidebar region available in main page template
- #3167174: Apply the node form meta column pattern to other entity types
- #3025646: Create a Style Guide
- #3251278: [META] Designs for dark background layers and its color palette
- #3254202: Remove IE11 Support from Claro
Claro beta criteria
Once the following level of feature completeness has been reached, we will consider tagging beta release for Claro:
- No known data integrity or security issues
- Everything that requires a big BC break has been solved
- Claro supports complex content authoring tasks including most prominent contrib modules (limited validation done by maintainers of Claro acceptable at this point)
- Claro supports most commonly used admin pages
- All commonly used global components have been designed and implemented
Must-haves for the beta release:
Features
- #3023319: Card Style Update
- #3036732: Action link component
- #3023310: Vertical Tabs style update
- #3023301: Messages style update
- #3024395: Password Field Style Update
- #3049321: Mini pager
- #3023326: Field Cardinality Style Update
- #3032365: Table drag style update
- #3021092: Image field style update
- #3021094: File field style update
- #3023320: Entity Reference Style Update
- #3074893: Change the delete button to use an action link
Bugs
- #3067386: AJAX rebuild of Views UI form re-renders parts of the form without using Form API, so additional hooks are needed in lieu of hook_form_view_edit_form_alter()
- #3067085: Views top dropbutton breaks when editing a view
Core inclusion
- #3084069: Allow marking themes as experimental - Drupal Core issue for adding necessary tooling for marking themes as experimental.
- #3084189: Import variables.css manually - Claro issue to make PostCSS build compatible with Drupal Core.
- #3060153: Use PostCSS in core, initially only for Claro - Drupal Core issue for adding PostCSS tooling.
- #3084388: Document for theme regions in claro as compared to seven's
- #3086435: Add automated test coverage for Claro
- #3087189: Resolve or work around claro.settings.yml implicit dependency on Shortcut
Should-haves for beta stability
Accessibility
Not scoped
Comment | File | Size | Author |
---|---|---|---|
#141 | Olivero-9.1.8-Edit-menu-Case_comunidade.png | 76.79 KB | GuilhermePuentes |
Comments
Comment #2
ckrinaComment #3
lauriiiComment #4
finnsky CreditAttribution: finnsky at Skilld commentedComment #5
finnsky CreditAttribution: finnsky at Skilld commentedComment #6
ckrinaComment #7
lauriiiMoved dialog, status report and media support to stable blockers instead of beta blockers based on discussion with @ckrina, @webchick and @Gábor Hojtsy.
Comment #8
ckrinaComment #9
xjmComment #10
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedAdding #3080100: Assess accessibility of Claro in High Contrast AKA forced colors mode. Some problems found described there already.
Comment #11
saschaeggiThanks @Andrewmacpherson!
Comment #12
ckrinaComment #13
ckrinaComment #14
lauriiiComment #15
lauriiiComment #16
bnjmnmAdded #3082672: Form prefix/suffix redesign in Claro
#3082685: Action links on admin/appearance
#3082688: Excess space between details summary and details content does not match design.
#3082691: Excess space on tables with action links and "show row weights" toggle. Does not match design. to stable must-haves.
Added #3082694: Extra space between message and content when content has elements with margin-top to should-haves.
Comment #17
webchickUpdating the issue statuses.
Comment #18
webchickAdding #3084069: Allow marking themes as experimental to the must-have list.
Comment #19
xjmTagging for FM and RM review once this is all filled out. (I believe @webchick indicated that the product team has already identified their must-haves above.)
One thing that's a must-have for me is that the roadmap include a longterm plan to deprecate and remove Seven. So, there should be a post-stable section that includes stuff like:
The roadmap should also include any specific bugs, tasks, etc. that would be needed in terms of architecture, documentation, whatever to make Claro a Seven replacement.
Finally, the roadmap also needs an issue to decouple Claro from Classy, since that's a D9 must-have for our longterm theme architecture plans.
Comment #20
shimpyDocument for theme regions in claro as compared to seven's. #3084388: Document for theme regions in claro as compared to seven's found this in one of the discussion in Add Claro administration theme to core. So created a issue for same. I am putting this as could be for stable release. Please edit if required.
Comment #21
shimpyI am addressing one of the issue #3080994: Spacing in Claro pushes content down, requiring much scrolling discussed in #3079738: Add Claro administration theme to core commments. which is not mentioned in road map
Comment #22
shimpyAddressing one more issue #2958282: Links inside surrounding text fail WCAG Use-of-Color in Seven theme as per comments in #3079738: Add Claro administration theme to core. Marking as Could-have issues for stable release
Comment #23
shimpyComment #24
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedMoving #2958282: Links inside surrounding text fail WCAG Use-of-Color in Seven theme to must-have for stable release, because it relates to WCAG level A.
#19: A post-stable section is a good idea. For accessibility triage, it gives us some extra breathing space for high-impact should-haves.
Comment #25
shimpy@andrewmacpherson #24 thanks for moving the issue for correct release.
Comment #26
shimpy#3005403 also affects Claro. That's an example of an issue present in Seven that we should also add as a stable blocker for Claro, because it's borderline-critical (it'd be critical if LB were in Standard, for example). Addressing this issue in Claro Roadmap in must have stable release.
Comment #27
shimpyComment #28
shimpyComment #29
lauriiiComment #30
lauriiiComment #31
lauriiiComment #32
lauriiiComment #33
lauriiiComment #34
lauriiiComment #35
lauriiiComment #36
lauriiiComment #37
saschaeggiComment #38
lauriiiComment #39
effulgentsia CreditAttribution: effulgentsia at Acquia commentedI think we should add at least some minimal test coverage to the must-have list. Even if it's just a single test function similar to what we have for BartikTest and ClassyTest. Or maybe a subclass of
InstallUninstallTest
that executes all of the same stuff but with Claro as the Admin theme.An example of something a test like that would catch is that currently,
claro.settings.yml
includes a shortcut setting, but Claro does not have a dependency on shortcut module, so that's something that should fail config validation when shortcut isn't enabled.Unfortunately, I don't think there's a way to easily test config validity outside of running a test. #2414951: Validate configuration schema before importing configuration is an issue to perform validation during import (in the UI, not only during tests), but that's not in core yet, and the latest patch on that issue isn't working correctly. But if we have an automated test, then that should catch it, since we automatically perform config validation during test runs.
Comment #40
lauriiiI talked with @ckrina to scope the non-scoped issues.
Comment #41
lauriiiComment #42
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedStarting to add a list of things that we ought to review before marking Claro as beta stage. What I'd like to see is a more detailed level of review. We can spin off child issues to capture the reviews, and I'll clarify the WCAG aspects, and offer testing advice.
Chatted with @lauriii about this, and a lot of it can be done on screen shot evidence. For things like zoom, reflow, text resize, and text spacing.
For screenshots evidence, it will be a good idea to include browser UI, so we see things like evidence of browser zoom level.
More to come, will flesh out in the next few days.
Comment #43
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented#3057772: Ambiguous icons for collapsing/expanding menu items is already listed as a usability must-have.
It's also arguably an accessibility failure of WCAG success criterion 3.2.4 Consistent Identification (level AA). Explained in a comment on that issue.
Comment #44
lauriiiAdded #3086435: Add automated test coverage for Claro to the beta-blockers to address #39.
Comment #45
xjmPer #3079738: Add Claro administration theme to core comments #61 through #63, listing the accessibility testing issues as should-haves for beta, but re-listing them as must-haves for stable also. So the only must-haves are the minimum requirements for core inclusion, the MVP feature-set, and one bug that has been flagged as critical.
Thanks!
Comment #46
xjmOops, copied a couple issues too many.
Comment #47
lauriiiComment #48
svettes CreditAttribution: svettes at Acquia commentedStatus summary:
Risks related to the 8.8 release:
Next steps:
All dates are asipriational!
Comment #49
xjmAgain, what is unclear? I feel like the beta requirements are very clearly fleshed out in the IS here, and the release managers have already given feedback on what we need for Claro to be included in a tagged release.
Comment #50
xjmLast night @webchick reluctantly agreed with me that under experimental policy, #3067386: AJAX rebuild of Views UI form re-renders parts of the form without using Form API, so additional hooks are needed in lieu of hook_form_view_edit_form_alter() could be committed during the theme's alpha phase, since the Views UI not being terrible could be considered part of the MVP and there's no specific requirements for horrible bugs to be fixed before alpha unless they affect security, data integrity, or the upgrade path. However, @webchick indicated that we would strongly prefer it be done before the theme is committed as an alpha module, because it will interfere with testing of the theme.
So based on that, we agreed to make it a should-have for alpha instead of a must-have, but it's still must-have before beta. The IS is accurate already since it lists the beta requirements, not the alpha require,ents.
That said, again, this issue is a priority to fix sooner rather than later compared to the other beta requirements, and having it in before 8.8.0-alpha1 would be ideal.
Comment #51
effulgentsia CreditAttribution: effulgentsia at Acquia commentedAdding #3087189: Resolve or work around claro.settings.yml implicit dependency on Shortcut to the must-have list, because it's a potential data integrity issue.
Comment #52
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedFleshed out a manual test plan for #3087225: [META] Assess Claro's conformance with WCAG Text spacing, Text resize, and Reflow.. More to follow for the Resize text and Reflow criteria.
Re. #45
For these WCAG resize/adaptation robustness criteria, I'm attempting to find achievable approaches for a first-pass survey prior to beta.
A good beta-stage assessment for these would be full-page captures from the Styleguide and Error style modules with a variety of browser/OS settings, or CSS bookmarklets applied.
Those can give us a good overview, before making a more detailed assessment prior to stable. We can approach the various layout and colour adaptation (high contrast) surveys this way.
Comment #54
xjmUntagging as per #3079738-80: Add Claro administration theme to core comments #80 and #81. The roadmap is really clear. Be sure to keep adding new issues that are identified to it (e.g. the JavaScript should-haves that were identified by @justafish).
We'll re-review the roadmap when we're targeting a stable release.
Comment #55
lauriiiComment #56
lauriiiComment #57
lauriiiComment #58
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThe roadmap in the IS looks great to me, and I agree that Claro is ready to be considered beta once #3067386: AJAX rebuild of Views UI form re-renders parts of the form without using Form API, so additional hooks are needed in lieu of hook_form_view_edit_form_alter() and #3067085: Views top dropbutton breaks when editing a view are complete.
Comment #59
effulgentsia CreditAttribution: effulgentsia at Acquia commentedAll the beta must-haves are done, so #3088437: Cherry pick Claro to Drupal 8.8.!!!
Comment #60
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedUpdate on some of the accessibility reviews which were marked should-have for beta.
Comment #61
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedComment #62
Thirugnana Sambandam CreditAttribution: Thirugnana Sambandam commentedComment #63
Thirugnana Sambandam CreditAttribution: Thirugnana Sambandam commentedComment #64
saschaeggiComment #65
lauriiiComment #66
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedUpdatin the accessibility issues for stable. Moving remaining accessibility issues from beta.
Comment #67
lauriiiComment #68
lauriiiComment #69
lauriiiAdded #3105597: Copy block configuration from admin theme when enabling an admin theme to the issues not yet scoped.
Comment #70
lauriiiComment #71
geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commentedQQ, don't know if this is the right issue to ask in—is 'dark mode support' something that's considered for the path to stability—or is that a feature addition that might be considered later? And in either case, is there an existing issue for dark mode support in Claro or not? My Drupal sites are one of a few places where things are nice and dark normally, but go to edit a page and wham-o, I get hit with a glaring bright white screen.
Comment #72
saschaeggi@geerlingguy something to consider for the future. We already did some exploration on the design side of things for a dark mode but it's still far away from being implemented at this point.
Comment #73
ckrinaComment #74
lauriiiComment #75
lauriiiComment #76
lauriiiComment #78
Ambient.Impact@geerlingguy I too would love a dark mode and have the same experience lately.
Comment #79
saschaeggi@Ambient.Impact @geerlingguy a lot happened since my last comment. You can already get a Darkmode if you install the Gin Admin Theme - which is based on Claro.
Comment #80
Ambient.Impact@saschaeggi That's pretty awesome, thanks!
Comment #81
lauriiiScoped the issues with @webchick, @Gábor Hojtsy, @ckrina.
Comment #82
lauriiiMore scoping with @webchick, @Gábor Hojtsy, @ckrina.
Comment #83
lauriiiComment #84
bnjmnmAdding dependee issues to some items in roadmap for better visibility.
Comment #85
bnjmnmComment #86
Nelo_Drup CreditAttribution: Nelo_Drup commentedHi, I don't know if it is the right place, but there is an important bug in /admin/config/content/formats when you create a new format, for example Custom, the tabs of CKEditor plugin settings are all hidden with display none.
Note: this is shown if I put display visibility and in teroria there must be 6 tabs
Comment #87
bnjmnmComment #88
bnjmnmComment #89
bnjmnmComment #90
bnjmnmComment #91
bnjmnmComment #92
rainbreaw CreditAttribution: rainbreaw as a volunteer commentedComment #93
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedDiscussed #3127466: Required fields are not identifiable on Internet Explorer 11 high contrast with @rainbreaw today. We'd like to bump it to major/must-have, because indicating required fields is a WCAG level-A need. Detailed remarks in comment #14 there.
Comment #94
bnjmnmComment #95
bnjmnmComment #96
bnjmnmComment #97
bnjmnmComment #98
bnjmnmComment #99
bnjmnmComment #100
jwilson3If the variable names in the css files can be considered an API, then probably #3155531: Naming convention of color shades in the Drupal Design System (e.g. for Claro) should be on this list as a stable blocker otherwise it might never get fixed once the project become stable.
Comment #101
lauriiiReplaced #3105597: Copy block configuration from admin theme when enabling an admin theme with #3156362: Add default block configuration to Claro in the roadmap.
Comment #102
jwilson3Comment #103
lauriiiMoved #3045467: Allow overriding module CSS without overriding their toolbar styles from should-haves to could-haves.
Comment #104
lauriiiComment #105
ckrinaComment #106
yoroy CreditAttribution: yoroy at Roy Scholten commentedComment #107
lauriiiDiscussed with @ckrina, @yoroy, @Antoniya and @saschaeggi and we agreed that we should descope the sidebar region from the stable blocking issues to be something we work on post-stable. Claro does not use, or support sidebars at the moment. We could start to use it, but that needs a lot of effort to make it work well. That should not be part of declaring Claro stable because it can be provided later, and we don't have any stable blocking issues needing it. This is also not a regression because Seven doesn’t provide a sidebar either.
Comment #108
lauriiiComment #109
DyanneNovaRemoving #3085219: Installer is not very usable in Claro from Must-haves for stable release. This is a must have for making Claro the default theme, but not a must have for a stable release.
Comment #110
lauriiiAdded #3116377: Autocomplete input in views exposed filters does not align with select and text inputs to the should haves issues.
Comment #111
lauriiiComment #112
lauriiiComment #113
lauriiiComment #114
batkorHi.
Please see this problem. https://www.drupal.org/project/claro/issues/3168242
Comment #115
lauriiiComment #116
lauriiiRemoved #3083039: Allow tabledrag to be disabled from the stable blockers because it is a new feature that shouldn't be specific to Claro.
Also removed #3084910: Insert tabledrag changed mark after the drag handle, and not after the last item in the cell from the stable blockers because there's a way for Claro to change that behavior without having to override the whole tabledrag library.
Comment #117
lauriiiComment #118
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedAdding #3169014: Semantic regression: Claro treats tableDragToggle as a link instead of a button.
Comment #119
lauriiiIt seems like #3092296: Improve email address field description at /user/register was marked as a should have for the stable release until it was marked as a blocker for #3082672: Form prefix/suffix redesign in Claro which is a stable blocker. After it was removed from the blockers of #3082672: Form prefix/suffix redesign in Claro, it was kept in stable criteria mistakenly. I'm moving it back to should have issues.
Comment #120
lauriiiDiscussed #3155531: Naming convention of color shades in the Drupal Design System (e.g. for Claro) in the Claro call today. We don't think it should be a stable blocker because it doesn't have end user impact. Claro will also remain internal after being marked stable, so we can make the change later.
Comment #121
lauriiiDiscussed with @ckrina, @saschaeggi and @Gábor Hojtsy and we decided to remove #3083044: Prevent line breaks in draggable (first) table cells from the roadmap given that it's a pre-existing problem.
Comment #122
NiklanComment #123
Nelo_Drup CreditAttribution: Nelo_Drup commentedHi problem with Paragraph and File Entity Browser display corrupt
https://imgur.com/a/xKNhtsD
Comment #124
saschaeggiComment #125
saschaeggi@Nelo_Drup #3092181: Nested Paragraphs create multiple drag handles
Comment #126
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedI think #3070558: Implement bulk operation designs should be moved from must-have to could-have. Surely it won't be a disaster if the bulk operation controls are arranged the same way as they are with Seven.
The patch in that issue has caused a lot of accessibility problems. Proposed workarounds are elaborate (and sometimes bizarre), and I'm not convinced they're safe. I'm unwilling to rush this one.
Comment #127
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented#3171726: Claro Shortcuts star fails WCAG Use of Color and Non-text contrast is a WCAG level-A failure, and wasn't added to this roadmap yet.
Comment #128
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commented#3171726: Claro Shortcuts star fails WCAG Use of Color and Non-text contrast is a WCAG level-A failure, and wasn't added to this roadmap yet.
Comment #130
effulgentsia CreditAttribution: effulgentsia at Acquia commentedMoved completed stable-must-haves to a Completed section.
Comment #131
effulgentsia CreditAttribution: effulgentsia at Acquia commentedMissed one.
Comment #132
effulgentsia CreditAttribution: effulgentsia at Acquia commentedComment #133
rrafferty313 CreditAttribution: rrafferty313 commentedHas anyone seen issues between Claro and the Simple hierarchical select Module? We've been experiencing a problem where the select fields disappear and cache has to be cleared to restore them.
Comment #134
effulgentsia CreditAttribution: effulgentsia at Acquia commentedMoving #3062751: Media and media library and #3061042: Status Report Page Update to Completed.
Comment #135
JeroenTI'm also experiencing the bug reported over here: #3183425: [backport] Google Chrome 87 renders fieldset with grey artefacts
Is this something that should be added to the list of bugs in this issue?
Comment #136
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer commentedAdding #3194669: Misuse of explicit colour for active pager item in -ms-high-contrast media query as a must-have, because it involves a WCAG level-A failure. It's easily fixed.
Comment #137
Gábor HojtsyParenting to easy out of the box :)
Comment #138
volkswagenchickAdding
Easy Out of the Box
tag.Comment #139
ckrinaRearranging issues so the Beta ones already done stay at the end.
Comment #141
GuilhermePuentes CreditAttribution: GuilhermePuentes commentedOlá GALERA da comunidade DRUPAL, essa minha primeira interação com você!
Uma obervação não domino o idioma inglês vou google tradutor.
Gostaria de propor um link de atralho para a pagina de [novo tipo de conteúdo].
Dentro da pagina novo tipo de conteudo navegue até a [aba configurações do menu],
na imagem eu tentei ilustrar minha ideia, no titulo da lista de menus já existentes ao lado colocar ou criar um link de atalho para a pagina [../admin/structure/menu/add] coloquei o icone do lapis veja os prints para ilustrar.
Olivero 9.1.8 (Tema padrão, experimental theme)
Seven 9.1.8 (Tema padão seven)
Disponibilizo o link do meu figma:
https://www.figma.com/file/IgiaaWPcIiien0xoHDF0s9/Theme-Claro-end-Olivero
ENGLISH VERSION
Hello GUYS from the DRUPAL community, this is my first interaction with you!
An observation I do not master the English language I will google translator.
I would like to propose a link to the [new type of content] page.
Within the new content type page, navigate to the [menu settings tab],
in the image I tried to illustrate my idea, in the title of the list of existing menus next to place or create a shortcut link to the page [../admin/structure/menu/add] I put the pencil icon see the prints to illustrate .
Olivero 9.1.8 (Standard theme, experimental theme)
Seven 9.1.8 (Standard seven theme)
I provide the link of my figma:
https://www.figma.com/file/IgiaaWPcIiien0xoHDF0s9/Theme-Claro-end-Olivero
Comment #142
pixeliteWelcome GuilhermePuentes! I like your idea of linking to menu settings page from the content type config page (although I can't seem to access the Figma link you included).
I think you should probably create a separate issue for this, because this would mean adding a feature/improvement to Claro.
You can also collaborate on UX improvements in the #UX channel on the Drupal Slack (https://www.drupal.org/join-slack).
Comment #143
GuilhermePuentes CreditAttribution: GuilhermePuentes commentedThanks for the @pixelite reception, I’m happy with your comment, I hope to contribute much more.
I will update the figma link for public beginner failure.
For your guidance on creating a new issue (create a separate issue) I have not yet learned how to create a new resource.
Regarding the slack group, I managed to get in. Thanks for sharing! See you soon!
Comment #144
GuilhermePuentes CreditAttribution: GuilhermePuentes commentedThanks for the @pixelite reception, I’m happy with your comment, I hope to contribute much more.
I will update the figma link for public beginner failure.
For your guidance on creating a new issue (create a separate issue) I have not yet learned how to create a new resource.
Regarding the slack group, I managed to get in. Thanks for sharing! See you soon!
Comment #145
joelpittetAdded bug that we almost have a working test for... #3177415: Vertical Tabs CSS classes applying to non-vertical tab detail element groups
Comment #146
ckrinaAdding #3222995: Implement chips based autocomplete designs as a could have so it gets referenced.
Comment #147
ckrinaReferencing #3251278: [META] Designs for dark background layers and its color palette as post-stable work.
Comment #148
ckrinaCleaning up summary from completed tasks.
Comment #150
ckrinaReferencing #3254202: Remove IE11 Support from Claro as post-stable work.
Comment #151
lauriiiTriaged the stable blockers with @ckrina, @saschaeggi, @Gábor Hojtsy and @bnjmnm.
Moved to should haves:
On top of that, we thought that it would be helpful if the accessibility topic maintainers could triage the accessibility stable blockers and add any issues that need to happen before stable to this issue. We also ran out of time to triage the vertical tabs issues.
Comment #152
mherchelNot sure if this is the right place to say this, but we should consider descoping the the vertical tabs issues out of Claro so the the fixes can be used by all other themes (including contrib, and custom themes). There's no reason why the accessibility features and UX improvements should be Claro-only.
Comment #153
joelpittetComment #154
Gábor Hojtsy#3169014: Semantic regression: Claro treats tableDragToggle as a link instead of a button was closed in favour of #3083051: Refactor tabledrag when core issues are resolved which was fixed, so removing from issue summary.
Comment #155
lauriii#3171726: Claro Shortcuts star fails WCAG Use of Color and Non-text contrast was moved to the Shortcut module issue queue because the bug exists in all core themes.
Comment #156
lauriiiComment #157
lauriiiAdded #3248239: Links in the tour tip body are visually the same as the rest of the text - Claro theme and #3219921: Claro: display the vertical scrollbar when many results are returned by linkit to the roadmap.
Comment #158
effulgentsia CreditAttribution: effulgentsia at Acquia commentedMoving #3123811: Grey text in Claro theme failed accessibility and #3248239: Links in the tour tip body are visually the same as the rest of the text - Claro theme to Completed section.
Comment #159
ckrinaRemoving #3068696: Tables overflow on mobile as stable blocker.
Comment #160
andregp CreditAttribution: andregp at CI&T commentedComment #161
ckrinaAdding child a11y issues as must-have/stable blokers:
#3080100: Assess accessibility of Claro in High Contrast AKA forced colors mode
Comment #162
ckrinaUpdate fixed issues.
Comment #163
mherchelMoving the following to completed:
Comment #164
ckrinaRemove some unneeded criteria for stable.
Comment #165
bnjmnmUpdated roadmap with should-haves surfaced by the recently closed #3088562: [META] Assess Claro for WCAG colour contrast AA conformance
Comment #166
ckrinaRemoving #3081489: Remove duplicate code from veritcal-tabs.js in Claro and #3088562: [META] Assess Claro for WCAG colour contrast AA conformance from the stable criteria list since they're already fixed.
Comment #167
ckrinaAlso #3087225: [META] Assess Claro's conformance with WCAG Text spacing, Text resize, and Reflow..
Comment #168
ckrinaRemoving #3163810: [META] Assess conformance with WCAG SC 2.4.7 "Focus Visible". Just one more to go!
Comment #169
ckrinaLast one #3080100: Assess accessibility of Claro in High Contrast AKA forced colors mode!!Not yet, I was too fast...Let's continue in #3277053: Mark Claro as Stable.
Comment #171
mherchelCan this be closed now since Claro is stable?
Comment #172
ckrinaComment #173
ckrinaFinally closing this issue because Claro became stable in #3277053: Mark Claro as Stable. Let's continue improving Claro on the issue queue. Thanks everybody involved by all your work!!
Comment #174
Ambient.Impact🙌🎉