Problem/Motivation

Claro has changed the semantics of the table-drag "show row weights" control from button to link.

When using any other core theme, this control is a <button type="button">.

Link isn't the correct element for this control. It isn't behaving as a hyperlink.

Proposed resolution

Change it back to a <button>

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

andrewmacpherson commented
Priority: Normal » Major
andrewmacpherson’s picture

andrewmacpherson commented
Issue summary: View changes

Back in #3079738-32: Add Claro administration theme to core, I said I was worried that Claro having lots of JS overrides would open up a lot of potential for accessibility regressions. This change from button to link is a good example of that.

Does Claro make any other arbitrary semantic changes like this?

Adding this as a must-have for the Claro stability road map.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

There's an issue dedicated to stripping out the majority of the tabledrag JS overrides #3083051: Refactor tabledrag when core issues are resolved. I uploaded a patch yesterday that includes the removal of the override that results in the button becoming a link (I was quite pleased to do that). There's a bit more to do before I can set it to Needs Review, but that issue is considered a must-have stable blocker so it will be prioritized appropriately. I believe this can be closed as a duplicate, but I won't perform the status change as I recall you requesting that you'd prefer accessibility maintainers make that call on issues tagged "Accessibility".

andrewmacpherson’s picture

andrewmacpherson commented

Hmm, that issue is about removing Claro's tabledrag.js overrides after some core issues are resolved, but..

  • It doesn't explain why Claro has replaced the button with a link in the first place, or mention the button vs. link problem at all.
  • Restoring the button in Claro's tabledrag.js override doesn't have to wait for any other core issues. Wasn't that the point in having an override in the first place?

So I don't think there's any justification to intentionally delay fixing this regression. I'm not in favour of closing this issue as a duplicate; that would set a poor precedent that fixing accessibility regressions can arbitrarily wait.

If the other issue fixes the problem before marking Claro stable, it'll make this issue outdated. That's fine. But I don't want to conflate an accessibility regression bug with a task issue to clean up technical debt. Those are clearly separate concerns, and it would be poor triage to call this one a duplicate. The "must-have" status of a clean up task could change.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I believe the change was made to try to resolve problems described in #3030987: Refactor usage of button component on links which I think you raised on an earlier discussions. It seems like the solution should have been to make the button to look like button, rather than changing it to link.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Closed (duplicate)

Closing this in favor of #3083051: Refactor tabledrag when core issues are resolved.