Problem/Motivation

When #3277053: Mark Claro as Stable is done, we can make Claro the default admin theme for Drupal core.

Proposed resolution

  1. Get Claro to stable: #3066007: Roadmap to stabilize Claro
  2. #3277053: Mark Claro as Stable

User interface changes

All Drupal installations will have Claro as the administration theme when they're installed.

Release notes snippet

Claro is the new default admin theme.

CommentFileSizeAuthor
#18 PXL_20220427_041024177.MP_.jpg760.38 KBwebchick

Issue fork drupal-3277057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckrina created an issue. See original summary.

Gábor Hojtsy made their first commit to this issue’s fork.

Gábor Hojtsy opened merge request !2167

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Make Claro the default admin theme » Make Claro the default admin theme in Standard profile
Status: Active » Needs review

Opened an MR with a small patch to make it the default in standard profile.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -Needs product manager review

Already signed off on #3066007: Roadmap to stabilize Claro including the recent updates, I don't think for myself there would be more to sign off here. 🤞

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Ok with 83 fails asserting various Seven things, this is a bit out of the scope of what I have energy to fix myself. Any takers? Its mostly about fixing up backend tests.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Needs work

So this is the only remaining fail and seems to be related to vertical tabs:

1) Drupal\Tests\standard\Functional\StandardTest::testStandard
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "Audio file" not found.

/var/www/html/vendor/behat/mink/src/WebAssert.php:636
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:1075
/var/www/html/core/profiles/standard/tests/src/Functional/StandardTest.php:247
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

From here:

      // The source field should be shown before the vertical tabs.
      $test_source_field = $assert_session->fieldExists($media_type->getSource()->getSourceFieldDefinition($media_type)->getLabel(), $form)->getOuterHtml();
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

This should IMHO be postponed to figure what exactly to do with vertical tabs.

tedbow made their first commit to this issue’s fork.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Acquia commented
Status: Needs work » Needs review
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and at GitLab commented

I’m so excited! 🤩

lauriii made their first commit to this issue’s fork.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs release manager review

Claro is now stable so we can now do this.

Also discussed with @catch on Slack and he signed off on this.

  • webchick committed eff874c on 9.4.x 
    Issue #3277057 by Gábor Hojtsy, tedbow, lauriii, ckrina, saschaeggi,...

  • webchick committed c72b6e6 on 10.0.x 
    Issue #3277057 by Gábor Hojtsy, tedbow, lauriii, ckrina, saschaeggi,...

webchick credited bnjmnm.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at MongoDB commented
Status: Reviewed & tested by the community » Fixed

COMMITTED AND PUSHED TO 10.0.x AND 9.4.x YEEAAAAHHHH!!!

GREAT work everyone!!!! This is SO great!! :D

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at MongoDB commented
FileSize
PXL_20220427_041024177.MP_.jpg760.38 KB

ACTION SHOT!

webchick doing a live commit with Lauri and Cristina flanking on the sides

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +Portland2022
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue tags: +9.4.0 release highlights

🥳 🥳 🥳

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.4.0 release notes

Tagging for the release notes too since this is a change for new site installation.

Go team! So happy to see this after all the years making this theme awesome.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.