Problem/Motivation

Views UI tabs are currently rendered using menu-local-task.html.twig in combination with duplicating contents of menu-local-tasks.html.twig in a #prefix and #suffix. Even though there's some similarities between the markup generated for these elements, design wise they are different.

The current solution is prone to errors since frontend developers theming local tasks would be unlikely to take into account that Views UI uses these templates for generating its markup.

Proposed resolution

Create a new template for rendering Views UI tabs. Change the markup so that it's unique to the Views UI by renaming tabs to views-tabs.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Admin UI Modernisation initiative
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I also found Drupal.behaviors.viewsUiRenderAddViewButton which does some markup preprocessing. We could probably remove that as well. Since that is tightly coupled to the tabs, my recommendation is to refactor that in this issue as well.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Create a new template for rendering Views UI tabs. » Create new template for rendering Views UI tabs.
manuel garcia’s picture

manuel garcia commented
Related issues: +#2489654: Make displays appear like local tasks in the Views UI instead of custom UI design
quiron’s picture

quiron
Primary language Catalan
Location Barcelona
commented
Issue tags: +Needs design

As long this is part of the Admin UI Modernisation initiative, after talking with @ckrina I mark it as Needs design to clarify the final UI of this element.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.