[meta] Admin theme: path to beta and stable

Added 2 more child issues.

Because there is support for the Book module I searched for other deprecated extensions. There are results for "classy", "contact" and "forum".

$ for ext in activity bartik classy seven stable ban book contact forum hal history quick rdf statistics tour; do git grep -ilw $ext core/themes/default_admin;done
core/themes/default_admin/templates/classy/README.txt
core/themes/default_admin/templates/classy/content/comment.html.twig
core/themes/default_admin/templates/classy/content/media-embed-error.html.twig
core/themes/default_admin/templates/classy/content/node.html.twig
core/themes/default_admin/templates/classy/content/search-result.html.twig
core/themes/default_admin/templates/classy/dataset/forums.html.twig
core/themes/default_admin/templates/classy/field/file-audio.html.twig
core/themes/default_admin/templates/classy/field/file-video.html.twig
core/themes/default_admin/templates/classy/misc/progress-bar.html.twig
core/themes/default_admin/tests/src/Functional/AdminTest.php
core/themes/default_admin/css/components/jquery.ui/theme.css
core/themes/default_admin/css/components/jquery.ui/theme.pcss.css
core/themes/default_admin/templates/classy/dataset/forum-icon.html.twig
core/themes/default_admin/templates/classy/dataset/forum-list.html.twig
core/themes/default_admin/templates/classy/dataset/forums.html.twig
core/themes/default_admin/templates/classy/user/forum-submitted.html.twig
core/themes/default_admin/css/components/system-admin--links.css
core/themes/default_admin/css/components/system-admin--links.pcss.css
core/themes/default_admin/font/inter.woff2

The classy templates date from when classy was removed from core and the templates were copied to all of the core themes, so probably came from Claro originally, but e.g. I'm pretty sure the admin theme doesn't need to override the node template, nodes generally won't get rendered in the admin theme at all, and it probably doesn't have styling based on it either. So we probably need an issue to try deleting those templates where we can, or moving them out of the classy folder if they need to stay. Forum templates can just be deleted entirely though. So may one for templates from deprecated/removed modules and one for the other classy templates?

These are the child issues for the last comment.
#3581831: Remove support for Book and Forum Module
#3582018: Remove or move the uses of classy templates in default admin theme

@jurgenhaas, I see my issue summary updates were removed. What was wrong with them?

@quietone I'm so sorry. Nothing was wrong with them. I had added the 3 new issue references and did that in a browser tab that was open for a couple of days, not realizing that there had been updates to it that I didn't have in my open tab yet.

I've restored your changes, I hope I got them all right.

Created #3585823: [Meta] Improve the accessibility of the Default Admin theme for copying Gin issues into, and updated the IS.

Another issue completed

Working with @jurgenhaass and @mgifford and @bernardm28 on a call to discuss this.

In a Slack discussion with core product managers, they want this beta level in three weeks (11.4) and stable by 12.0 (December)

https://drupal.slack.com/archives/C7AB68LJV/p1779785392682889

Added two issues for items in the 'Stable blocker' section.

Stable blocker in, #3614911: JS aggregation returns 400 for libraries loaded in the header only as dependencies

Met with @jurgenhaas and @mgifford this morning over Zoom. We triaged all the issues.

This issue is listed under the "Not a blocker" section (item 26 in the list). I assume that's an error, but I'm not familiar enough to be certain.

I think we need issues (maybe under a separate meta?) to use default_admin in the standard profile + umami. If we have that meta, I'd also move the installer issue under that - those issues are blocked by default_admin being stable rather than the other way around.

I'll break these out a bit more later today

Reorganizing done!

10 stable blockers!

Down to 8 stable blockers!

Down to 7! Fixed a BIG one with #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme

I don't think #3580137: Document sub-theme behavior and theme settings inheritance should be a stable blocker, we don't have a full write-up for Claro after several years on this policy, so why would it be a blocker now?

Also I think it would be good to define what the actual scope is of #3618216: Add automated tests to Default Admin we can always add more test coverage of everything, are there specific, critical things missing test coverage?

I was looking into the deprecation of Claro and found that there are 16 instances of 'claro' in Default Admin.

$ git grep -ni claro | grep core/themes/default_admin
core/themes/default_admin/css/theme/accent.css:41:[data-admin-focus="claro"] {
core/themes/default_admin/css/theme/accent.pcss.css:37:[data-admin-focus="claro"] {
core/themes/default_admin/images/core/README.md:3:should be removed before moving Claro to Drupal core. See
core/themes/default_admin/images/core/README.md:4:https://www.drupal.org/project/claro/issues/3045216 for details.
core/themes/default_admin/src/Settings.php:295:        'claro' => $this->t('Legacy green'),
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:14:    "pattern": "'claro' =>",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:19:    "pattern": "data-admin-focus=\"claro\"",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:24:    "pattern": "data-admin-focus=\"claro\"",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:49:    "pattern": "Claro",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:54:    "pattern": "project/claro",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:104:    "pattern": "(?:gin|claro)",
core/themes/default_admin/tests/fixtures/implementation-name-allowlist.json:109:    "pattern": "(?:Gin|Claro)",
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php:145:    $name_pattern = '/(?:\b(?:gin|Gin|claro|Claro)\b'
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php:146:      . '|(?<![A-Za-z])(?:gin|claro)(?=[._-]|[A-Z])'
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php:147:      . '|(?<![A-Za-z])(?:Gin|Claro)(?=[A-Z]))/';
core/themes/default_admin/tests/src/Unit/ImplementationNameTest.php:166:      if (preg_match('/(?:gin|claro)/i', $file->getFilename())) {

That should be dealt with in #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme which is only in main so far - does that mean it missed more references or were you looking prior to that landing?

I just built a new test setup and yes, the same results as above on main. And it is the same result on 11.x

Reading this comment, maybe accent.pcss.css should be data-accent.pcss.css?

Added #3621981: Remove admin-custom.css which is blocking the deprecation of Claro. And moved the doc issues to completed

#3618971: Use Admin theme in installer is in. I think we need an equivalent issue for Umami still

#3587668: Apply to selected items button has low contrast under blockers is 'needs more info now' - should that be moved to nice to haves / needs triage?

For the record I don't think #3580137: Document sub-theme behavior and theme settings inheritance should block stable, it's more of a policy decision and doesn't actually affect functionality at all.

That leaves two accessibility issues, one form bug, and tests. It's not clear to me what the scope of the testing issue is for stable blocking. There are issues switching/copying claro testing over to default_admin which should be adding some implicit testing at least.

There are issues switching/copying claro testing over to default_admin which should be adding some implicit testing at least.

The theme also has some tests currently, and I'm adding tests in some issues.

#3587668: Color contrast in admin and claro under blockers is 'needs more info now' - should that be moved to nice to haves / needs triage?

It's outdated. Moved to completed (title also changed).

Updating IS, as #3605702: Remove remaining Gin and Claro implementation names from Default Admin theme is not fully fixed.

Few small ones landed.

Removing #3580137: Document sub-theme behavior and theme settings inheritance, since it is not a bug specific to the Admin theme.

#3621244: Navigation mobile sidebar close button in dark mode has low color contrast landed

Adding #3623385: Admin theme's status report styling is off as a stable blocker. Should be an easy fix.

Added #3623388: Details summary summary has low contrast to blockers because my understanding is @mgifford considers all color contrast issues to be blockers.

Added #3623407: Broken tabledrag UI when uploading multiple files in Admin theme to blockers

Moved #3619426: Sidebar in entity edit forms moves to form bottom if an ajax handler refreshes the form out of blockers into "Not a blocker". Explanation and details in an issue comment there.

Remove superflous info from summary.

Moved the tests #3618216: Add automated tests to Default Admin out of blockers as discussed and agreed in Slack with @mherchel, @catch, and @longwave

🙌

Another color contrast issue for blockers: #3629776: View edit page buttons have low contrast

@kentr Admin is already stable. We can knock this out soon, but there are no more stable blockers FYI.

@kentr we marked default_admin stable in #3624359: Remove "lifecycle: experimental" from Admin's info.yml for the 11.5.x and 12.0.x branches, when we reached zero known blocking issues here.

This was also a necessary step for moving Claro to contrib so that we don't have two admin themes in core until 2030 (we'll already be supporting Claro until 2028 in Drupal 11, at least for security, even if no longer really fixing most bugs in the core version).

Newly found accessibility issues can still be prioritised, and we still have six weeks until 12.0.0/11.5.0 is out to fix them before default admin is stable in a stable core release.

I removed that one I added from the IS.