Problem/Motivation

There are classy templates in the default admin theme.

$ git grep classy core/themes/default_admin/
core/themes/default_admin/templates/classy/content/comment.html.twig:  {{ attach_library('claro/classy.indented') }}
core/themes/default_admin/templates/classy/content/media-embed-error.html.twig:{{ attach_library('claro/classy.media_embed_error') }}
core/themes/default_admin/templates/classy/content/node.html.twig:{{ attach_library('claro/classy.node') }}
core/themes/default_admin/templates/classy/content/search-result.html.twig:{{ attach_library('claro/classy.search-results') }}
core/themes/default_admin/templates/classy/dataset/forums.html.twig:{{ attach_library('claro/classy.forum') }}
core/themes/default_admin/templates/classy/field/file-audio.html.twig:{{ attach_library('claro/classy.file') }}
core/themes/default_admin/templates/classy/field/file-video.html.twig:{{ attach_library('claro/classy.file') }}
core/themes/default_admin/templates/classy/misc/progress-bar.html.twig:{{ attach_library('claro/classy.progress') }}
core/themes/default_admin/templates/classy/navigation/book-navigation.html.twig:{{ attach_library('claro/classy.book-navigation') }}

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582018

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Title: Remove or move the uses of classy template in default admin theme » Remove or move the uses of classy templates in default admin theme

quietone’s picture

Status: Active » Needs review
mherchel’s picture

Status: Needs review » Needs work

I created a visual regression tool at https://github.com/mherchel/ddev-drupal-admin-vrt to help with the CSS refactor. Its still kind of a work in progress, but it works.

It found a number of regressions here. I haven't dived into them (they could just be some small things at the top of the page that throw everything off), but we need to get into it.

Setting to NW, and will likely dive into this a bit later (if time)

mherchel’s picture

Status: Needs work » Needs review

Yep. Default Admin was using the block, region, and page title templates. I moved these into the appropriate directories.

Visual regression tests are passing now. Should be good to go!

dharizza’s picture

Status: Needs review » Reviewed & tested by the community

This is looking good! I checked the MR, did some manual testing and confirmed the new templates are used, I also run the VRT tool and can confirm all tests are passing. Thank you!

bernardm28’s picture

Ran the VRT tool and everything works as expected.

I also looked for two templates that were replaced for deeper inspection.
/admin/content/ loads block.html.twig from classy, and after switching to the new PR branch, everything loads fine.

Before

before image

After

after image

I also visually inspected the title on /admin/content/comment,
which used to load from default_admin/templates/classy/content/page-title.html.twig.

Before
before

after

after comments

catch’s picture

Should we have a follow-up to evaluate the use of the last three templates from classy?

mherchel’s picture

Should we have a follow-up to evaluate the use of the last three templates from classy?

I'm not sure why we'd need to.

godotislate’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f8d6aab to main. and e2642d9 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • godotislate committed f8d6aab0 on main
    task: #3582018 Remove or move the uses of classy templates in default...

  • godotislate committed e2642d97 on 11.x
    task: #3582018 Remove or move the uses of classy templates in default...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.