This can be viewed on admin/content

This is a CSS source order issue.

CommentFileSizeAuthor
#6 before-full.png192.93 KBf0ns
#6 after-full.png192.39 KBf0ns
Content___Drush_Site-Install.png23.22 KBmherchel

Issue fork drupal-3619688

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

mherchel opened merge request !16898

mherchel changed the visibility of the branch 3619688-button-misaligned-in to hidden.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review

Fixed! Ready for review.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Just pushed a another commit using the new after key. See https://www.drupal.org/node/3467489

f0ns’s picture

f0ns commented
StatusFileSize
new after-full.png192.39 KB
new before-full.png192.93 KB

Just setup a clean Drupal install on main to test this with some dummy content.

Before

Before

After

After

f0ns’s picture

f0ns commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented

It's nice to see after in the wild, however I'm wondering whether we actually need that, and instead whether this library should depend on the global styling library instead? In practice it's only going to get loaded when the global library is loaded anyway, so maybe it doesn't matter as such, but we should probably pick the one that is semantically better since e.g. it might matter in contrib cases that copy core. Leaving RTBC.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

I think after is correct semantically here. It's not a dependency issue, it's more source order. But I also don't feel very strongly.

Eventually, we're going to clean up global-styling in #3614876: Clean-up libraries-overrides in default_admin.info.yml. It's loading a good amount of styles unnecessarily. We'll be changing things around a bit then.

  • catch committed a289f4af on 11.4.x 
    fix: #3619688 Button misaligned in exposed filters within Admin theme...

  • catch committed 5b34da10 on 11.x 
    fix: #3619688 Button misaligned in exposed filters within Admin theme...

  • catch committed 4b79a822 on main 
    fix: #3619688 Button misaligned in exposed filters within Admin theme...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

That all sounds good, thanks for confirming.

Committed/pushed to main, 11.x and 11.4.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.