Problem/Motivation

From #3618906: [Meta] Forms sidebar accessibility issues

It's hard to get into the sidebar by keyboard.
Try: TAB to the toggle control, press ENTER to expand the sidebar, then TAB to enter the sidebar.
Since it's effectively functioning as a modal with regard to the rest of the form, it should probably have a keyboard trap (shouldn't be able to TAB out of it onto the obscured main form).
Or perhaps it should close when you TAB out of it so that the main form isn't obscured. This probably causes failure of WCAG SC 2.4.11 Focus Not Obscured (Minimum) (Level AA).

The tab sequence within the sidebar is messed up. It goes: Revision log message -> close button -> Published.

From #3618906: [Meta] Forms sidebar accessibility issues:

For the close button, I'm fairly confident that we can just remove it, since the toggle button exists.

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Crediting @kentr in issue credit due do discovery in #3618906: [Meta] Forms sidebar accessibility issues

kentr’s picture

kentr commented

By accident I think figured out why the tab sequence inside the sidebar is off.

There's a form container named default_admin_sidebar that contains the close button and the Published (aka status) field.

But the element that contains all of the elements in the sidebar is actually the advanced container.

This default_admin_sidebar container is inside the advanced container.

So, the Revision log message field precedes the close button in the DOM.

In the DOM, the sidebar is id="edit-advanced" and this inner element with the close button is id="edit-default-admin-sidebar".

kentr’s picture

kentr commented
Issue summary: View changes

From #3619154: Accessibility fixes for Admin theme's sidebar toggle control:

For the close button, I'm fairly confident that we can just remove it, since the toggle button exists.

kentr’s picture

kentr commented

Though, the open sidebar obscures the toggle button when the Navigation module is disabled.

IMO the presence of the close button is important in that case.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Related issues: +#3619387: Indicate on forms sidebar toggle button that sidebar has child element errors

Could we hide it if the Navigation module is enabled?

kentr’s picture

kentr commented

@mgifford,

It's doable from a technical perspective. The theme has other code that changes when Navigation is enabled.