Followup from #3615331: Invalid ARIA attribute aria-toolbar-link__labelledby on toolbar menus strips their accessible name.

We need to see if menu-region--middle.html.twig and menu-region--top.html.twig are ever in use. If not, we can remove them

Issue fork drupal-3619804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

f0ns’s picture

f0ns commented

They seem to be unused.

All three came in with the Gin merge (9fc3187d, #3556948) and were never wired up: default_admin declares no hook_theme(), and its hook_theme_registry_alter() repoints only toolbar and menu__toolbar at templates/navigation.

The navigation module's hook_theme() registers top_bar*, block__navigation, navigation_menu, navigation_content_top and navigation__messages — no menu_region base hook, so there's nothing for menu-region--top/middle/bottom to attach to.

Nothing includes them from Twig either.

Worth adding menu-region--bottom.html.twig to the scope, looks like that is the same situation.

f0ns’s picture

f0ns commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Can we update the issue summary to still follow the standard issue template please. To include your findings.

Since they're not used probably safe to go ahead and remove them.

longwave-bot made their first commit to this issue’s fork.

longwave opened merge request !16926

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Looks like these two are also unused?

core/themes/default_admin/templates/page/page--clone.html.twig
core/themes/default_admin/templates/page/page--group.html.twig
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review