[D7] jQuery form styler

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2828745

Project 2: https://www.drupal.org/node/2828967

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Below are my reviews

1) Please use module_exist or function_exist before in function form_styler_plugin_loaded for $jquery_form_styler = libraries_load('jquery_form_styler');

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) On module enable, there is no message displayed for library installation. Please provide some information on library installation and module setup.
2. (*)There is no error message or warning displayed to user on admin/config/user-interface/form-styler page even if the library is not installed.
3. (+) In form_styler_form_alter() function, use condition to check form ids that are added in admin/config/user-interface/form-styler config page. Currently, the form styler library is loaded on all the pages that have forms and if library is available.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@armrus ,

Yes you are right.

@armrus,

Few more findings after module updation,

• (+) In form_styler_form_alter(), you have used \n to explode form ids. There can be \n or \r\n. Recommend to use PHP_EOL instead.
• Rename git clone command in issue description as the module name (form_styler) is different from module folder name (jquery_form_styler).
• Provide some examples on module page for how to customize Drupal form elements using this plugin.

The plus sign (+) items are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Please address above findings, as they are not application blocker though, moving it to RTBC. I will approve it if there are no objections for a week.

Also add the instructions of how to install a library without drush command on project page.

But otherwise looks good to me. No objections for more than a week.

Thanks for your contribution, armrus!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.