[D7]ArCa payment system

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @hayk.hayrapetyan

I'd made a little code review.

1. Provide comment on functions
2. Seems there is some problems with a line indents.

2. Use hook_uninstall for deleting these varibales.

variable_get('epayarca_gateway_merchant_number')
variable_get('epayarca_gateway_backurl')
variable_get('epayarca_gateway_password')

Thanks

Hi @hayk.hayrapetyan

I'd made a little code review.

1. Provide comment on functions
2. Seems there is some problems with a line indents.
3. Use hook_uninstall for deleting these varibales.

variable_get('epayarca_gateway_merchant_number')
variable_get('epayarca_gateway_backurl')
variable_get('epayarca_gateway_password')

Thanks

Hi Hayk.
First time check coding standarts.

Automated Review

See online review result on https://pareview.sh/node/25

Manual Review

Individual user account

Yes: Follows.

No duplication

Yes: Does not cause.

Master Branch

No: Does not follow the guidelines for master branch.

Licensing

Yes: Follows.

3rd party assets/code

Yes: Follows.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows.

Secure code

No: List of security issues identified.

1. (*) File api.php rename file name and change php extension to inc (ex. EPayArcaApi.inc), after write in your info file autoload file path ( files[] = EPayArcaApi.inc) See Writeing module info file post

Coding style & Drupal API usage

List of identified issues in no particular order:

1. (+) For file api.php (after renamimng) Check coding standards in file api.php and use Drupal api fucntions. Ex.: line 10: change date('dmy') to format_date.
2. (+) At line 9-11 module you declare hook_help() implements, but hook code is not writed...
3. (*) At 12-14 Lines Remove debug info settigns from module file.
4. Line 116 module file. not use Include once. See above in this comment.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

p.s. After fixing this, renew your issue about review. (Sorry for my bad English... =) i can write this message translated to Armenian language).

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.