[D7] Alias checker

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Check auto review from Pareview.sh https://pareview.sh/node/105

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order:

1. (+) Create install file and write hook_uninstall() for deleting variable 'alias_checker_import_line_max'

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Below are my review point:

1. Please create hook_help.
2. in alias_checker.inc line 73,74 variable should be initialise on top.
3. in alias_checker.inc line 120 , 147 ,166 , 198function name should start with your module name.
4. in alias_checker.inc line 129,132 use t() for drupal set message.
5. in alias_checker.inc line 181 else statement must use brases.

Hi @ishwar:

There are some issues while checking the module:
-> Spelling mistake in page "admin/config/search/alias_checker". It should be "Alias Checker" rather than "Alieas Checker".
-> After uploading .csv it is redirecting to "alias-checker" and showing as "PAGE NOT FOUND".
-> Still there are issues in pareview.sh

Please review your code on "https://pareview.sh" site. We found some issue in your code. Here I have attached the link for your error code.

https://pareview.sh/node/105

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.