[D7] Google Analytics Vimeo Video Tracking

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2545934

Project 2: https://www.drupal.org/node/2542176

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi ARUN AK,
1. There is no need of so many blank lines in between the tags in the *.info file. Just leave an extra line at the end of the file.
2. Get the path to library by libraries_get_path('library') instead of hardcoded path(sites/all/libraries) in the *.module file as well as *.install file.
3. We generally do not code the js in the *.module file itself. So it is recommended that you move the entire code

 drupal_add_js(array('googleanalytics_vimeo' => array('progress25' => variable_get('googleanalytics_vimeo_progress25', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('progress50' => variable_get('googleanalytics_vimeo_progress50', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('progress75' => variable_get('googleanalytics_vimeo_progress75', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('videoPlayed' => variable_get('googleanalytics_vimeo_videoPlayed', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('videoPaused' => variable_get('googleanalytics_vimeo_videoPaused', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('videoResumed' => variable_get('googleanalytics_vimeo_videoResumed', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('videoSeeking' => variable_get('googleanalytics_vimeo_videoSeeking', FALSE))), array('type' => 'setting'));
  drupal_add_js(array('googleanalytics_vimeo' => array('videoCompleted' => variable_get('googleanalytics_vimeo_videoCompleted', FALSE))), array('type' => 'setting'));

to a separate place, and access it here instead.
4. It is better to use current_path() instead of $_GET['q']. Please make changes in your *.module for the same.

Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
Meets coding style and api guidelines

Couple of observations
drupal_add_js(drupal_get_path('module', 'googleanalytics_vimeo') . '/googleanalytics_vimeo.js', array('scope' => 'footer')); - would it still work if you used $page['#attached']['js'][] = here?
Would make d8 upgrade easier and would be cache-safe.

Ingoogleanalytics_vimeo_settings() you could use '#type' => 'checkboxes' for 'googleanalytics_vimeo_tracking_options' and simplify the code.

In the admin code $visibility == 2 this would best be served with a constant, for readability (2 seems magic).

Are you totally wedded to supporting php.module and php based visibility? If so, you should try an integrate with paranoia module. If you can live without it, I'd remove it - one less vector.

In googleanalytics_vimeo_admin_config_js you can add this in one call to drupal_add_js, just build a keyed array.

In the JavaScript you loop over $.each(vimeo_iframes, function (index, iframe) twice - can this be combined into a single pass?

I note also you use vimeo_iframes = $('iframe'); could you not use vimeo_iframes = $('iframe[src*=player.vimeo.com]'); and filter the result from the onset?

Other than these observations - this looks well coded and care has been taken with the module - thank you for contributing to Drupal.

Review of the 7.x-1.x branch (commit fa137a1):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/googleanalytics_vimeo.inc
  ---------------------------------------------------------------------------
  FOUND 2 ERRORS AFFECTING 2 LINES
  ---------------------------------------------------------------------------
   13 | ERROR | [x] Array indentation error, expected 4 spaces but found 6
   23 | ERROR | [x] Array closing indentation error, expected 2 spaces but
      |       |     found 4
  ---------------------------------------------------------------------------
  PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ---------------------------------------------------------------------------
  

• ESLint has found some issues with your code (please check the JavaScript coding standards).

/home/klausi/pareview_temp/googleanalytics_vimeo.js: line 33, col 7, Error - "vimeoGAJS" is not defined. (no-undef)
/home/klausi/pareview_temp/googleanalytics_vimeo.js: line 34, col 14, Error - "vimeoGAJS" is not defined. (no-undef)

2 problems

FILE: /home/klausi/pareview_temp/googleanalytics_vimeo.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
 32 | WARNING | Open page callback found, please add a comment before the
    |         | line why there is no access restriction
---------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

The settings page can be edited by any anonymous user, which is a security blocker right now. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Hi Arun,

I did PAReview and found following issue

Review of the 7.x-1.x branch (commit fa137a1):

• ESLint has found some issues with your code (please check the JavaScript coding standards).

googleanalytics_vimeo.js: line 33, col 7, Error - "vimeoGAJS" is not defined. (no-undef)
googleanalytics_vimeo.js: line 34, col 14, Error - "vimeoGAJS" is not defined. (no-undef)

2 problems

Review of the 7.x-1.x branch (commit fe32e09):

• ESLint has found some issues with your code (please check the JavaScript coding standards).

/home/klausi/pareview_temp/googleanalytics_vimeo.js: line 8, col 3, Error - Strings must use singlequote. (quotes)
/home/klausi/pareview_temp/googleanalytics_vimeo.js: line 22, col 28, Error - Strings must use singlequote. (quotes)

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. googleanalytics_vimeo_requirements(): do not concatenate the argument message passed to $t(), otherwise it is hard to get the string for automated translatable string extraction tools.
2. googleanalytics_vimeo_page_alter(): if you are only adding stuff to the page render array you should use hook_page_build() instead.
3. googleanalytics_vimeo_js_alter(): why is that hook needed? You are already adding the JS to the footer in googleanalytics_vimeo_page_alter()? Please add a comment.

Otherwise looks good to me. Assigning to Ayesh as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, ARUN AK!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.