This module creates a new FairCoin address field type, that is available to attach to any entity. When user introduces the FairCoin address, the module validates it. When the field is displayed, it presents a qr-code if address text is clicked.

Installation

  • Download and install the Libraries API 2 module.
  • Download the qrcode.js plugin.
  • Unpack and rename the plugin directory to "qrcode" and place it inside the "sites/all/libraries" directory. Make sure the path to the plugin file becomes: "sites/all/libraries/qrcode/jquery.qrcode.min.js"
  • Download and install Faircoin address field module.

Project page:
https://www.drupal.org/sandbox/xavip/2539964

Git instructions:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/XaviP/2539964.git faircoin_address_field

Pareview review:
http://pareview.sh/pareview/httpgitdrupalorgsandboxxavip2539964git

Manual reviews of other projects

https://www.drupal.org/node/2267557
https://www.drupal.org/node/2541230
https://www.drupal.org/node/2524740
https://www.drupal.org/node/2542176

Comments

xavip’s picture

xavip commented
Issue summary: View changes

Added valid faircoin addresses for testing proposals.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

xavip’s picture

xavip commented
Issue summary: View changes
Issue tags: +PAreview: review bonus

Added manual review links for review bonus tag.

arun ak’s picture

arun ak commented

Hi,

Please fix the syntax error found in faircoin_address_field.inc line no 55, 59 and 66. The array syntax used here is wrong.

Please use
$valids = array(self::MAINNET_PUBKEY, self::MAINNET_SCRIPT);
instead of
$valids = [self::MAINNET_PUBKEY, self::MAINNET_SCRIPT];

Use module_load_include() function instead of required_once in line no 91.
found : 

require_once drupal_get_path('module', 'faircoin_address_field') . '/faircoin_address_field.inc';

try

module_load_include('inc', 'faircoin_address_field', 'faircoin_address_field');

Regards,
ARUN AK

arun ak’s picture

arun ak commented
Status: Needs review » Needs work
xavip’s picture

xavip commented
Status: Needs work » Needs review

Corrections made. @ARUN AK Thank you!

xavip’s picture

xavip commented
Title: [D7] Faircoin address field » [D7] FairCoin address field
Issue summary: View changes
viswanathan6’s picture

viswanathan6 commented

Hi ,

it is recommended to add hook_install() in your .install file.

xavip’s picture

xavip commented

@viswanathan6 Can you explain why is recommended? I don't find information about that. I can implement hook_install but I don't know what to put inside since all the module needs is performed by hook_schema. I've been looking in examples module but I can't find why. Even the field_example module doesn't use it.

viswanathan6’s picture

viswanathan6 commented

@Xavip It is recommended to always implement hook_install(). Here you can find an example.

xavip’s picture

xavip commented

@viswanathan6 Ok, thank you. Added hook_install and hook_requirements.

xavip’s picture

xavip commented
Issue summary: View changes

QR code behavior change in summary issue.

esteve.badia’s picture

esteve.badia commented
Status: Needs review » Reviewed & tested by the community

The code seems ready to be promoted to a full project to me. Furthermore this developer has already contributed substantially to other (full) projects.

xavip’s picture

xavip commented
Title: [D7] FairCoin address field » [D7] Faircoin Address Field

@esteve.badia thank you for your review.
I wait for promoting the module to full project, to benefit from the drupal.org translation and continuous integration services.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

manual review:

  1. faircoin_address_field_field_formatter_view(): do not use drupal_add_js/css() here, use #attached on the $element render array instead. See https://api.drupal.org/api/drupal/developer--topics--forms_api_reference...
  2. faircoin_address_field_field_formatter_view(): don't call theme() here, just add the image as array to the render array. Drupal will render everything later for you and an unrendered array is easier to alter for others. See https://www.drupal.org/node/930760

But otherwise looks good to me, so ...

Thanks for your contribution, XaviP!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

xavip’s picture

xavip commented
Issue summary: View changes

Removed checking address.

Thank you klausi!
I'll check this two issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.