[D7]Chinese identity card

This is a quick review. First code documentation should be in English for the Doc blocks. Also refer to Drupal coding standards.

You have numerous coding issues that need to be addressed:
http://pareview.sh/pareview/httpgitdrupalorgsandboxivanzhu2513696git

Hi ivanzhu,
1. Your README file is not as per the Drupal Guidelines. Please refer to guidelines for in-project documentation and/or the README Template.
2. Please rename your *.test file to *.inc and make the changes wherever the name for this file is concerned.
3. Instead of using array_key_exists(), please use isset() in your *.module.
4. As far as I could get from your code, you are attempting to create a textfield, which is working fine. Does it accepts the date of birth or something else? I have tried all possible inputs including the DOB, numbers or characters. But irrespective of the input, it gives the error message "the input may not be valid". So is it a misunderstanding on my part regarding the inputs or something to be done from your side. Your README also explains nothing about the things.

Change the status to "Needs Review" when all things are sorted.
And take part in Review Bonus Program to have a higher priority.

1) It would be better if your *.info file looks like:

name = Chinese identity card
description = A specifc field for chinese identity card.
core = 7.x
package = Fields
dependencies[] = field

files[] = chinese_identity_card.inc

2) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

3) I have found below error when I entered 15 digit(511702197701193) ID Numbers for 'Chinese Identity card' field and save that new node.
Exception: DateTime::__construct(): Failed to parse time string (1919-77-01) at position 6 (7): Unexpected character in DateTime->__construct() (line 277 of D:\xampp\htdocs\demosite\sites\all\modules\chinese_identity_card\chinese_identity_card.module).

Automatic Review

Pareview says: error in chinese_identity_card.module line 26.
It would be nice to put the link to your pareview review on the issue summary.

Manual Review

Individual user account

Yes

No duplication

Yes

Master Branch

Yes

Licensing

Yes

3rd party assets/code

Yes

README.txt/README.md

Yes

Code long/complex enough for review

Yes

Secure code

Yes

Coding style & Drupal API usage

Just some recommendations:

1. Correct errors marked on pareview.
2. Please, provide on your issue summary some valid chinese identity card numbers for testing proposals.
3. Please, provide a link to your pareview review on the issue summary..
4. I doesn't agree with comment #3: the test file should be called .test, not .inc

This review uses the Project Application Review Template.

@ajalan065: In #3 you said:

2. Please rename your *.test file to *.inc and make the changes wherever the name for this file is concerned.

That is wrong. The .test extension is the proper file extension to use for SimpleTest test cases. You can read this in the Drupal SimpleTest coding standards.

Please don't RTBC your own issues, only another reviewer should do that.

manual review:

1. project page is too short. What is the use case of this module? How does it work? How does it extend Drupal? See also https://www.drupal.org/node/997024
2. chinese_identity_card_field_formatter_view(): I think #value should be sanitized with check_plain() since theme_html_tag() does not sanitize it to prevent XSS exploits. Usually the field values get validated when they are entered, but I would still always sanitize them since you never know how they ended up in the database (data migration or another module writing to the field or whatever).

Otherwise looks good to me, so I think this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Naveen as he might have time to take a final look at this.

Is this module re-inventing wheels?

@jimmyko: you mean there is already a similar module? Could you provide a link?

No objections for a week, so ...

Thanks for your contribution, ivanzhu!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.