[D7] Media Skyfish

Hi Andriuzss,

Your module Git URL is git clone --branch 7.x-1.x http://git.drupal.org/sandbox/andriuzss/2499627.git media_skyfish
Kindly change it to review all.

Manual Review:
Try to use drupal_http_request() instead of PHP Curl.
media_skyfish.utilities.inc

$process = curl_init($host);
  curl_setopt($process, CURLOPT_HTTPHEADER, $headr);
  curl_setopt($process, CURLOPT_HEADER, 0);
  curl_setopt($process, CURLOPT_TIMEOUT, 30);
  curl_setopt($process, CURLOPT_RETURNTRANSFER, TRUE);
  $return = curl_exec($process);
  curl_close($process);

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I went through your module. Please see my observations below:

1) Instead of loading files using php 'include_once', you can use module_load_include() function. Also by using this function you can load these inc pages particularly where it need to load.

2) Getting two warning messages while installing the module

• Warning: class_implements() [function.class-implements]: Class MediaSkyfishStreamWrapper does not exist and could not be loaded in file_get_stream_wrappers() (line 136 of C:\xampp\htdocs\www_d7_test2_com\includes\file.inc).
• Warning: in_array() expects parameter 2 to be array, boolean given in file_get_stream_wrappers() (line 136 of C:\xampp\htdocs\www_d7_test2_com\includes\file.inc).

3) Add configuration url(admin/config/media/media_skyfish) in media_skyfish.info file.

4) Add menu type for the url (user/%user/skyfish) as 'type' => MENU_LOCAL_TASK. Then it will display as new tab in user account page.

5) Please check this if statement is necessary in this config form media_skyfish_user_settings_form() if (!isset($usr->uid) || $user->uid != $usr->uid).

6) Try to use drupal_http_request() instead of PHP Curl in media_skyfish.utilities.inc.

Thanks,
ARUN

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxandriuzss2499627git

I'm a robot and this is an automated message from Project Applications Scraper.

Hi andriuzss
Code looks good to me. I've tested, and everything works as it should. I'm setting it to reviewed and tested.

Reviewed, code looks fine, working as expected.

Reviewed the code. Everything looks good and works fine.

1. Why not use https://api.drupal.org/api/drupal/includes!common.inc/function/drupal_ht... instead of curl?
2. Fix the link to skyfish.com on your project page

Regardless...

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues (here you get to ask fans of your project to help you!)

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.