ClickSpark.js module provide an easy way of integration Clickspark js with drupal website. ClickSpark.js is an open source particle effect tool for the frontend. It’s based on JavaScript and HTML5. ClickSpark.js adds beautiful particle effects to your JavaScript events. The special feature is that image files can be used as single particles. It’s easily configurable and flexible.

Drupal core version: 7.x

Other information

Module name: ClickSpark.js
Sandbox project page: https://www.drupal.org/sandbox/arun/2539730
Git repository: branch 7.x-1.x:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ARUN/2539730.git
PAReview:
http://pareview.sh/pareview/httpgitdrupalorgsandboxarun2539730git

Setting Repository:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ARUN/2539730.git clickspark_js
cd clickspark_js
CommentFileSizeAuthor
click_spark.png8.37 KBarun ak

Comments

arun ak’s picture

Issue summary: View changes
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

xavip’s picture

Status: Needs review » Needs work

1. README.txt:
It would be clearer if you put the whole link to download the js library.
Substitute this:
https://github.com/ymc-thzi/clickspark.js
with this:
https://github.com/ymc-thzi/clickspark.js/archive/master.zip

You may put this link in your project page too.

It would be better to explain in the text the name of the directory to put the library. It must be exactly 'clickspark.js'

You may include the link to PAREview in your issue summary:
http://pareview.sh/pareview/httpgitdrupalorgsandboxarun2539730git

2. If you use variables, you have to erase them on uninstall. You may follow this:
https://www.drupal.org/node/2274697

3. Add a config in clickspark_js.info to display a link in modules list:
configure = admin/config/clickspark_js/settings

4. Visiting admin page:
Notice: Use of undefined constant MAX_FILE_SIZE - assumed 'MAX_FILE_SIZE' in clickspark_js_settings() (line 65 of clickspark_js/clickspark_js.admin.inc).
It seems you have to surround the constant with single quotes:
'file_validate_size' => array('MAX_FILE_SIZE' * 1024 * 1024),

5. Saving admin page:
Notice: Trying to get property of non-object in clickspark_js_particle_image_path_form_validate() (line 129 of clickspark_js/clickspark_js.admin.inc).
It seems you have to use:
$image_info = image_get_info($file['uri']);
instead of:
$image_info = image_get_info($file>uri);

arun ak’s picture

Issue summary: View changes

Project page formatted and added PAReview link.

arun ak’s picture

Hi XaviP,

Thanks for the review and comments. Issues mentioned in your comment are fixed.

I checked this:

$image_info = image_get_info($file['uri']);
instead of:
$image_info = image_get_info($file>uri);

In this line:

$file = $form['clickspark_js_particle_image_path_file']['#file'];

in $file variable I am getting a file object instead of an array. So I didn't change my current code.

Thanks,
ARUN AK

arun ak’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Added manual review links for review bonus tag.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2545934

Project 2: https://www.drupal.org/node/2542176

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

arun ak’s picture

Issue summary: View changes
Issue tags: -PAreview: review bonus
avpaderno’s picture