[D7] ADFL

Timeout when invoking pareview.sh for http://git.drupal.org/sandbox/MarkConroy/2297203.git at http://pareview.sh/pareview/httpgitdrupalorgsandboxMarkConroy2297203git

Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Your sandbox must not contain the Drupal core, only your distribution.

Also contrib modules/themes should not be included, only mention them as dependencies in your .info file.

Please refer to documentation on how to make distributions in Drupal way.

Also take a look inside other Drupal distributions for examples.

Any distribution will always include the latest of Drupal core and some of contrib modules/themes, but only when it is downloaded. Drupal.org is responsible for this inclusion. But your repository should have only your specific distribution and the modules/features/themes you created specifically for this distribution if any. Without the rest. You only include that in dependencies.

See Commerce Kickstart repo, for example. There's no any other contrib stuff, only distrib itself and commerce_kickstart_ specific modules and themes. All contribs it needs are listed in dependencies section of commerce_kickstart.info, and contrib stuff versions and any patches it needs are in build-commerce-kickstart.make file.

And all this nuances of distribs are there, in further sections of documentation book.

Hi,

Automated Review
Giving some errors.
http://pareview.sh/pareview/httpgitdrupalorgsandboxmarkconroy2297203git

Manual review

README.txt/README.md file is missing
(*) No: Follows the guidelines for in-project documentation and the README Template.

The project page might need some styling(try to add some headers), just to make it simple to view.

You missing hook_uninstall in adfl.install.

Great job, but I think still some work needs to be done.

@markconroy I still see forks of contrib modules in http://cgit.drupalcode.org/sandbox-MarkConroy-2297203/tree/modules/contrib

That is not correct. Those should be defined in the .make along with the version of core used. While Drupal.org's packaging script will not run on the .make in a sandbox, you can run drush make locally.

Please read https://www.drupal.org/node/1432374

The reason you see core, modules, and themes in the downloads of distributions from Drupal.org is because of packaging based on the .make. What you are doing is both wrong and a violation of the Drupal Git Repository Usage policy.

Reviewing #2153139: Unpublish Distributions with Forks of Core < 7.32 might help understand why we require providing a pointer to the specific version of projects on Drupal.org as well as whitelisted libraries from other locations vs. simply committing a fork of the project in your distribution. You need to focus on what you see in the repositories of other distribution vs. what you see in the packaged downloads.

Does that make sense?

Distributions are often much more complicated than an individual module or theme normally reviewed to grant a new user the permission to create full projects, but the current project review process encourages users who know little or nothing about profiles and distributions to provide feedback.

Despite @stefank's well meaning suggestion, there is also no reason to include a hook_uninstall in a profile as there is no way to execute that hook. Profiles are designed to be used on install. Even with https://www.drupal.org/project/profile_switcher, an uninstall hook of an old profile that has been disabled is never run.

Looks good! The first thing I did was run

drush verify-makefile

. That requires https://www.drupal.org/project/drupalorg_drush, but is what the packaging script runs on full distribution projects so it is worth testing.

Starting Drupal.org contrib makefile validation, please wait         [ok]
Makefile drupal-org.make passed.                                     [ok]
Starting Drupal.org core makefile validation, please wait            [ok]
Makefile drupal-org-core.make passed.                                [ok]

The I used

drush make build-adfl_distribution.make -y

. That .make built the without errors...

Beginning to build build-adfl_distribution.make.                     [ok]
drupal-7.34 downloaded.                                              [ok]
adfl_distribution cloned from                                        [ok]
http://git.drupal.org/sandbox/MarkConroy/2297203.git.
Found makefile: drupal-org.make                                      [ok]
zen-7.x-5.5 downloaded.                                              [ok]
 >> Project views contains 2 modules: views, views_ui.
views-7.x-3.10 downloaded.                                           [ok]
token-7.x-1.5 downloaded.                                            [ok]
strongarm-7.x-2.0 downloaded.                                        [ok]
smartcrop-7.x-1.0-beta2 downloaded.                                  [ok]
sharethis-7.x-2.10 downloaded.                                       [ok]
pathauto-7.x-1.2 downloaded.                                         [ok]
 >> Project panels contains 5 modules: panels_mini, panels_ipe, i18n_panels, panels_node, panels.
panels-7.x-3.5 downloaded.                                           [ok]
multiupload_imagefield_widget-7.x-1.3 downloaded.                    [ok]
multiupload_filefield_widget-7.x-1.13 downloaded.                    [ok]
 >> Project metatag contains 10 modules: metatag_facebook, metatag_twitter_cards, metatag_panels, metatag_views, metatag_dc, metatag_context, metatag_opengraph, metatag_devel, metatag_google_plus, metatag.
metatag-7.x-1.4 downloaded.                                          [ok]
link-7.x-1.3 downloaded.                                             [ok]
libraries-7.x-2.2 downloaded.                                        [ok]
honeypot-7.x-1.17 downloaded.                                        [ok]
 >> Project google_analytics contains a module named googleanalytics.
google_analytics-7.x-2.1 downloaded.                                 [ok]
 >> Project flexslider contains 4 modules: flexslider_views, flexslider_fields, flexslider_example, flexslider.
flexslider-7.x-2.0-alpha3 downloaded.                                [ok]
field_group-7.x-1.4 downloaded.                                      [ok]
features-7.x-2.3 downloaded.                                         [ok]
 >> Project entity contains 2 modules: entity_token, entity.
entity-7.x-1.5 downloaded.                                           [ok]
 >> Project devel contains 3 modules: devel_generate, devel, devel_node_access.
devel-7.x-1.5 downloaded.                                            [ok]
 >> Project ctools contains 10 modules: ctools_plugin_example, term_depth, ctools_ajax_sample, bulk_export, ctools_custom_content, views_content, ctools_access_ruleset, page_manager, stylizer, ctools.
ctools-7.x-1.6 downloaded.                                           [ok]
 >> Project context contains 3 modules: context_ui, context_layouts, context.
context-7.x-3.6 downloaded.                                          [ok]
colorbox-7.x-2.8 downloaded.                                         [ok]
Found makefile: colorbox.make                                        [ok]
colorbox downloaded from                                             [ok]
https://github.com/jackmoore/colorbox/archive/1.x.zip.
ckeditor-7.x-1.16 downloaded.                                        [ok]
 >> Project bean contains 6 modules: bean_entitycache, bean_admin_ui, bean_all, bean_usage, bean_uuid, bean.
bean-7.x-1.8 downloaded.                                             [ok]
backup_migrate-7.x-3.0 downloaded.                                   [ok]
 >> Project admin_menu contains 3 modules: admin_menu_toolbar, admin_devel, admin_menu.
admin_menu-7.x-3.0-rc5 downloaded.                                   [ok]

Ran through the standard site install with no problems. Played around with the distribution. Did this error a few times in the log.

Notice: Trying to get property of non-object in drupal_alter() (line 1080 of includes/module.inc).

I also noticed FlexSlider library not found. That library is whitelisted so you can add it by adding this to your .make...

http://cgit.drupalcode.org/cm_starterkit_easy/tree/cm_starterkit_easy.ma...

When I tried to use the Image Gallery, I was able to upload the cover image and 1 additional image, but was given a 'The file could not be uploaded' error for additional images. Not sure if that's an issue with the configuration or my testing environment.

Other than those minor issues, this looks like a solid distribution. All of the contrib modules you've included are up to date. The Features all stay in their default state after installing (not a trivial accomplishment!)

Drupal currently compalins that the distribution and the custom modules/features you've added don't have versions and updates can't be checked, but that is by design. Once the packaing script adds a version to those, it will work as expected.

I tend to put pure Feature exports into a directory that is just modules/features or modules/custom vs. modules/custom/custom_features.

While you should continue to work on the issues I've pointed out, I'm moving this to RBTC. The review process is really focussed on modules and has been problematic for distributions in the past. For other would be distributions, I've suggested applying to be reviewed based on a single module in the distribution. Then, after getting the permission to create full projects, start you distribution.

This project is different in that the customized configuration that makes up the dsitribution is the project.

Great work!

Review of the 7.x-1.x branch (commit f8343c1):

• Remove "version" from the ./themes/custom/adflzen/adflzen.info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the ./themes/custom/adflzen/adflzen.info file, it will be added by drupal.org packaging automatically.
• Remove "datestamp" from the ./themes/custom/adflzen/adflzen.info file, it will be added by drupal.org packaging automatically.
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives. See attachment.
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. why is the machine name "adfl_distribution" and not simply "adfl"?
2. I think you can ignore the Coder warnings on the CSS files, since they are generated anyway, right?
3. adfl_pathauto_settings.inc is never included and can be removed, correct?

So as far as I see there is no custom code here, that I can review, correct? This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Should I promote the project as "adfl" or "adfl_distribution" for you?

Tagging.

Thanks for your contribution, markconroy!

I promoted this project for you: https://www.drupal.org/project/adfl_distribution

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

There is either something wrong with the way this project was originally created or the way is was promoted. If you look at the body classes of https://www.drupal.org/project/openatrium, you'll see node-type-project-distribution. While https://www.drupal.org/project/adfl_distribution, is node-type-project-drupalorg.

From what I understand about the content types on D.O, the drupalorg project type is reserve for nodes like https://www.drupal.org/project/drupal_lwg and https://www.drupal.org/project/drupalorg_whitelist

I don't think @markconoroy should even be able to create that type of project, so I'm guessing this was an mistake during the promotion.

The drupalorg.make is only processed during packaging for distribution. The packaging script is currently treating this like a module or theme.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2458731

Project 2: https://www.drupal.org/node/2297401

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

So as far as I can see the project needs to be deleted and you need to create a new project as distribution project and push all your git commits there. Please open a webmaster issue for that at https://www.drupal.org/project/issues/webmasters