[D7] CKEditor Image2

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjwilson32454995git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

HI jwilson3,

Very interesting module and will certainly be a valuable part of the ckeditor family.

Some comments on this. In your ckeditor_image2.info file you might consider setting a package for this module. I'd suggest "User Interface" so it resides in the modules list beside ckeditor and/or wysiwyg and other UI items.

The link in the README.md for 'widget' brought me to 404:
http://ckeditor.com/addons/widget
I think it should be:
http://ckeditor.com/addon/widget (no 's' after addon)

The same is true for Line Utils and DialogUI:
http://ckeditor.com/addons/lineutils (remove 's' after addon)
http://ckeditor.com/addons/dialogui (remove 's' after addon)

For some reason, I couldn't get image2 button to show (using wysiwyg module) unless I also enabled the image button.

Once installed I keep getting this notice:
Notice: Undefined index: removePlugins in ckeditor_image2_wysiwyg_editor_settings_alter() (line 100 of /Users/markconroy/htdocs/drupal-7/sites/all/modules/sandbox/ckeditor_image2/ckeditor_image2.module).

You might want to note in the README.md, or on the project page, that this approach adds classes such as align-left or align-right to your image, but does not actually result in the image positioning left/right - these classes need to be added to the theme. (Or you could include a small CSS file with this module.)

Your config.js file attempts to remove the width and height properties, but I didn't find that it worked. I was able to resize the image by one parameter - width or height (though at least the proportions were kept.

Caption worked very well.

+1 to see this as a full module

Thanks for writing this image2 integration code and submitting your project for review!

I noticed while testing that line 100 of ckeditor_image2.module that the following line should be changed:

      $settings['removePlugins'] .= 'image';

to

      $settings['removePlugins'] = 'image';

If the removePlugins key isn't set, we need to create it and set the value to 'image' instead of the concatenating it.

Automated Review

Pareview.sh shows so minors warnings- http://pareview.sh/pareview/httpgitdrupalorgsandboxjwilson32454995git

They should be address before the release but they are not blockers.

Coder Module: Show same warnings that Pareview.sh

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes : Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. Should fix all the warnings from Pareview.sh, before the release.
2. I think you should add the text "See addon page for more details." at the end of "Plugin for the Enhanced Image2 widget for CKEditor." It should looks something like this "Plugin for the Enhanced Image2 widget for CKEditor. See addon page for more details." Just to have consistency with the rest of plugins.
3. Add hook_help with some information about your module so users can have access at your module documentation in the Drupal UI.
4. ckeditor_image2.module - Line 12: You should consider adding your css hook_page_build() instead of hook_init. Because:
   

   hook_init() runs even on AJAX requests, private file requests, etc. hook_page_build() runs when we're only delivering HTML.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I do not see any blocker. This is a great module that should be promote it long time ago.

I have tested this and seems to be working well and meets the coding standards.

RTBC, Can someone promote this to project status and give james full access to create projects?

Bumping to Major just because this has been sitting here for too long.

I have tested too and worked pretty well, also the code meets the coding standards.

1+ to promote this project to full project.

I have been using this on a production site for over a month without any problems.

manual review: everything looking good.

Thanks for your contribution, jwilson3!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.