This module allows admins to create a twig template filter, written in PHP, directly in the administration interface.
Installation
No special installation requirements
Sandbox project page link:
drupal.org/sandbox/freeandeasy/2545860
To clone the project:
git clone --branch 8.x-1.x http://git.drupal.org/sandbox/FreeAndEasy/2545860.git twigfilter
How to use the module
Step 1: Create Filter
- go to /admin/config/system/twigfilter
- create a new filter by clicking the "Add Twigfilter" button
- name your filter and enter your filter code, save
Step 2: Use Filter
use your filter anywhere (template/views etc) like this:
{{ 'mytext'|twigfilter('my-filter-machinename') }}
Automated review results:
pareview.sh/pareview/httpgitdrupalorgsandboxfreeandeasy2545860git
Manual reviews of other projects
www.drupal.org/node/2422391
www.drupal.org/node/2450085
www.drupal.org/node/2427463
Comment | File | Size | Author |
---|---|---|---|
#15 | coder-results.txt | 1.51 KB | klausi |
Comments
Comment #2
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #3
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #4
gaja_daran CreditAttribution: gaja_daran commentedHi,
The clone project URL asking the password. The clone URL like as
Kindly update it.
Comment #5
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #6
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #8
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #9
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #10
FreeAndEasy CreditAttribution: FreeAndEasy commentedmet requirements of review bonus system https://www.drupal.org/node/1975228
Comment #11
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #12
jwilson3Automated Review
Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.
Manual Review
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
This review uses the Project Application Review Template.
Comment #13
FreeAndEasy CreditAttribution: FreeAndEasy commentedHi jwilson3,
thank you for the review. Can you download the latest changes from git? I fixed the error that you mentioned yesterday. It should work with rc1 and dev.
I also added additional help and warnings to the php input form.
Comment #14
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #15
klausiReview of the 8.x-1.x branch (commit 44fa9fa):
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #16
FreeAndEasy CreditAttribution: FreeAndEasy commentedThank you klausi, great review!
I fixed the PAReview warnings.
1. I added a better use case describtion to the project page.
2., 3., 4. Fixed.
5. I removed the input validation for now. Admins should be aware of the implications of using this module. Warnings are displayed right above the input form.
6. Thouse routes are needed in Druapl rc1, maybe they are not needed in later release candidates, I will investigate that.
No further review necessary until then.
Comment #17
FreeAndEasy CreditAttribution: FreeAndEasy commentedTested in RC3, edit/delete routes are necessary.
Comment #18
klausinope, they are not, as you can see in node module: there are no routes in the node.routing.yml file to edit or delete nodes.
Comment #19
FreeAndEasy CreditAttribution: FreeAndEasy commentedThe node module has its own route provider where the edit and delete routes are defined (look at NodeRouteProvider.php). Its not the same as configuration entities.
Comment #20
klausiI see, thanks for pointing that out!
#2350509: Implement auto-route generation for all core entities and convert all of the core entities. shows that it is possible (the API to do it is there already), but unfortunately that never landed.
Comment #21
FreeAndEasy CreditAttribution: FreeAndEasy commentedAdding review bonus tag again:
https://www.drupal.org/node/2573987#comment-10571228
https://www.drupal.org/node/2595933#comment-10570960
https://www.drupal.org/node/2593427#comment-10571366
Comment #22
FreeAndEasy CreditAttribution: FreeAndEasy commentedComment #23
klausiReview of the 8.x-1.x branch (commit 3336d25):
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
But otherwise looks good to me. Assigning to ELC as he might have time to take a final look at this.
Comment #24
klausiNo objections for more than a week, so ...
Thanks for your contribution, FreeAndEasy!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.