[D8] Node View Access

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Scanned the module quickly:

In node_view_access.install

/**
 * Implements hook_disable().
 */
function node_view_access_disable() {
  node_view_access_disabling(TRUE);
}

Per https://www.drupal.org/node/2193013 hook_disable() has been removed.

In node_view_access.module

hook_node_access() is missing $langcode

In NodeViewAccessPermissions.php

use Drupal\Core\Routing\UrlGeneratorTrait;

Is unused.

Automated Review

Pass

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Its a relative easy code, non the less very usefull

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

no issue's found

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Review of the 8.x-1.x branch

Really cool and useful module!

Automated Review

no issues

Manual Review

Individual user account

Yes: Follows

No duplication

Yes: Does not cause duplication and/or fragmentation

Master Branch

Yes: Follows guidelines for master branch

Licensing

Yes: Follows licensing requirements

3rd party assets/code

Yes: Follows guidelines for 3rd party assets/code

README.txt/README.md

Yes: Follows guidelines for in-project documentation and the README Template

Code long/complex enough for review

Yes: Follows guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

1. After enabling the module, there are no default view permissions granted, making the site inaccessible to users. I suggest granting the permission by default.

The module provides functionality which should have been implemented in D8 from the start.

There is no duplication, the code is well written and documented and the module respects the node grants system working well with core's grants and other permission granting modules (I tested it with ACL / Content access).
The module is working es expected.

FreeAndEasy mentioned, the viewing access should be granted upon the installation of the module to avoid an inaccessible site. I guess you could do that, but alternatively a warning should appear after enabling the module warning about all nodes being inaccessible until proper viewing permissions are set. Drupal users should be accustomed to explicitly set access.

All in all this should be very much a full dev project, setting it RTBC.

Thanks for your contribution, Marco!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.