[D8] CodeButton

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxalex432102427449git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Quick review:

In codebutton.module

use Drupal\Core\Config\Config;

Looks to be unused and you're calling \Drupal::config from the global scope anyway.

You have an extra line to remove below the use statements (line 11 or 12).

In codebutton.module and CodeButton.php

You could convert all array() with the PHP 5.4+ new short array syntax

Hi Alex,

I haven't installed this yet, so these comments are only from reading the code from the respository viewer.

Can you update your git address in the issue summary so we can get a proper clone of your code easier, as I have on my application here: https://www.drupal.org/node/2458731. I think yours will be:

git clone --branch 8.x-1.x http://git.drupal.org/sandbox/alex43210/2427449.git codebutton

Your README.md file is very short, you should add some more information there about who to install the module, if any configuration is needed, and what it does once installed.

GeSHi Filter hasn't been released yet for Drupal 8 (it's in a dev state) - does this leave any concerns for your module? If so, you might want to document them in the README.md file.

Line 22 of codebutton.module, perhaps change
drupal_set_message(t('You must add "pre" to "Generic syntax highlighting tags" option to let CodeButton work'));
to
drupal_set_message(t('You must add "pre" to "Generic syntax highlighting tags" option for CodeButton to work'));
and perhaps link "Generic syntax highlighting tags" to the correct page.

Line 2 of js/plugins/codebutton/plugin.js, move the text after @file to a new line. See here: https://www.drupal.org/coding-standards/docs#file

This file seems to use 4 spaces instead of 2 for indenting. See here: https://www.drupal.org/node/172169#indenting

Thanks for contributing this module.

@markconroy, this should be "Needs Work" instead of "Needs Review"?

@darol100,

Apologies. You are correct. Fixed now.

Thanks.

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxalex432102427449git

FILE: .../www/drupal-7-pareview/pareview_temp/js/plugins/codebutton/lang/en.js
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
2 | ERROR | [x] Doc comment short description must be on the first line
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: .../www/drupal-7-pareview/pareview_temp/js/plugins/codebutton/lang/pl.js
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
2 | ERROR | [x] Doc comment short description must be on the first line
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: ...r/www/drupal-7-pareview/pareview_temp/js/plugins/codebutton/plugin.js
---------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------
2 | ERROR | [x] Doc comment short description must be on the first line
31 | ERROR | [x] Expected 1 space after closing parenthesis; found ""
50 | ERROR | [x] Expected 1 space after FOR keyword; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Manual Review

Individual user account

Yes: Follows

No duplication

Yes: Does not cause duplication and/or fragmentation

Master Branch

Yes: Follows guidelines for master branch

Licensing

Yes: Follows licensing requirements

3rd party assets/code

Yes: Follows guidelines for 3rd party assets/code

README.txt/README.md

No: Does not follow the guidelines. Please add a full readme: https://www.drupal.org/node/2181737

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

No issues found.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.