Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
phpunit
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Mar 2019 at 10:15 UTC
Updated:
23 Jul 2026 at 15:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
lendudeComment #3
alexpottI think it would really great to try to come up with a list of people who have worked on the issues that has got us to this point and credit them here.
Comment #4
lendude@alexpott that would be amazing
Comment #5
michielnugter commentedCongrats to everyone and I'm glad I could contribute a little. I'm still sorry that I wasn't able to help it to completion but luckily there were a lot of people willing to help!
+1 on the removal from maintainers.txt
Comment #6
jibranYay!!!
Comment #7
alexpottLet's get the list first.
Comment #8
wim leersThe last issue to be tagged like this :)
Comment #14
lendudeIt's been a while, getting the list would be nice, but ¯\_(ツ)_/¯
Patch didn't apply anymore so rolled it into an MR
Comment #15
alexpottYeah I have no idea how to generate this list. I can't think of any fair way to do that. So let's proceed here.
Comment #16
dawehner+1 RTBC
The only thing I could think of is to get all contributors from:
1. https://www.drupal.org/project/drupal/issues/2735005 and its subtasks
2. https://www.drupal.org/project/ideas/issues/2807237 and its subtasks
3. Combine that with the 'phpunit initiative' tag
The question really though is, whether that's worth it to wait for.
Comment #17
xjmYep, get the NIDs of issues with the tag, then write a script to scrape the contributor list from those commits. Sort by frequency, dedupe, win.
Let's reach out to the DA once we have the list to see if we have a less invasive way to add the bulk crediting; bad things happened last time.
Comment #18
lendudeHere we go, contributors list based on all nodes tagged with 'phpunit initiative' and that had a commit in the git log. Distilled user names from the commit messages and used the API to match those to UIDs.
Some people have changed their user name, or are gone from d.o :(
I think we can find most of the people that changed name,
Comment #19
xjmThat's fantastic, thanks @Lendude!
Here's that list as a string:
dawehner, alexpott, michielnugter, naveenvalecha, Jo Fitzgerald, vaplas, ApacheEx, Mile23, borisson_, martin107, Wim Leers, jibran, GoZ, andypost, larowlan, nlisgo, jonathan1055, klausi, mpdonadio, claudiu.cristea, scuba_fly, Manuel Garcia, dagmar, vijaycs85, mondrake, Mixologic, Gábor Hojtsy, Berdir, xjm, boaloysius, Tessa Bakker, zviryatko, ziomizar, navneet0693, phenaproxima, snetcher, mglaman, yogeshmpawar, longwave, Dinesh18, catch, cspitzlay, zaporylie, hchonov, impalash, pasan.gamage, joachim, RytoEX, Meenakshi Gupta, shashikant_chauhan, nginex, justinlevi, tstoeckler, jhodgdon, proeung, Abhijith S, kostyashupenko, anmolgoyal74, sulfikar_s, mherchel, Spokje, scott_euser, nnevill, Utkarsh_Mishra, saurabh.tripathi.cs, Hardik_Patel_12, Krzysztof Domański, eliclaggett, roderik, msankhala, jhedstrom, pritish.kumar, NickWilde, babruix, m1r1k, tim.plunkett, ceardach, voleger, markdorison, dcam, MerryHamster, bapi_22, dan2k3k4, Pavan B S, brentgees, tanmayk, lomasr, bircher, hswong3i, legovaer, jmuzz, nuez, mkalkbrenner, gaurav.kapoor, Antonnavi, IRuslan, zahord, tameeshb, Mac_Weber, Ujin, quietone, maxocub, tar_inet, mohit1604, marcoscano, wengerk, sun, blazey, himanshu-dixit, esoteric1, droplet, cilefen, DuneBLAlso, making a better issue title for the log. :)
I'll reach out to infra and ask them if there's a way to do this bulk-crediting without a repeat of the D8MI situation.
Comment #22
gábor hojtsyComment #24
gábor hojtsyComment #32
gábor hojtsyComment #40
gábor hojtsyComment #47
gábor hojtsyComment #55
gábor hojtsyComment #64
gábor hojtsyComment #71
gábor hojtsyComment #73
gábor hojtsyProcessed all credits up to tstoeckler. Only vaplas is missing (a missing user now unfortunately). This was roughly half the credits. I think we should be fine doing the other half sometime later and then closing this. Congrats to everyone notified so far :)
Comment #74
naveenvalechaYay, congrats everyone!
Comment #86
gábor hojtsyComment #94
gábor hojtsyComment #106
gábor hojtsyComment #119
gábor hojtsyComment #134
gábor hojtsyComment #140
gábor hojtsyComment #141
gábor hojtsyThanks all for your hard work and congrats all! I added all users listed in #19 that are still on drupal.org following DA engineering feedback to go ahead.
Comment #142
alexpottCommitted and pushed 24dbbbc108 to 9.2.x and 24f3a9492e to 9.1.x. Thanks!
Comment #145
alexpottComment #146
lendudeJust to be sure everybody gets it, I quote from the IS:
a big thank you to all involved, your contributions have been amazing