The initiative is done, all Simpletests that needed to be converted, have been converted.

Discussed with @Lendude and @dawehener that we feel this constitutes the completion of our goals.

Again, a big thank you to all involved, your contributions have been amazing.

ON commit add initiative to https://www.drupal.org/core/maintainers/past

Issue fork drupal-3038234

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Lendude created an issue. See original summary.

lendude’s picture

Status: Active » Needs review
StatusFileSize
new625 bytes
alexpott’s picture

I think it would really great to try to come up with a list of people who have worked on the issues that has got us to this point and credit them here.

lendude’s picture

@alexpott that would be amazing

michielnugter’s picture

Congrats to everyone and I'm glad I could contribute a little. I'm still sorry that I wasn't able to help it to completion but luckily there were a lot of people willing to help!

+1 on the removal from maintainers.txt

jibran’s picture

Status: Needs review » Reviewed & tested by the community

Yay!!!

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Let's get the list first.

wim leers’s picture

Issue tags: +phpunit initiative

The last issue to be tagged like this :)

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

lendude’s picture

Status: Needs work » Needs review

It's been a while, getting the list would be nice, but ¯\_(ツ)_/¯

Patch didn't apply anymore so rolled it into an MR

alexpott’s picture

Yeah I have no idea how to generate this list. I can't think of any fair way to do that. So let's proceed here.

dawehner’s picture

+1 RTBC

The only thing I could think of is to get all contributors from:

1. https://www.drupal.org/project/drupal/issues/2735005 and its subtasks
2. https://www.drupal.org/project/ideas/issues/2807237 and its subtasks
3. Combine that with the 'phpunit initiative' tag

The question really though is, whether that's worth it to wait for.

xjm’s picture

Yep, get the NIDs of issues with the tag, then write a script to scrape the contributor list from those commits. Sort by frequency, dedupe, win.

Let's reach out to the DA once we have the list to see if we have a less invasive way to add the bulk crediting; bad things happened last time.

lendude’s picture

StatusFileSize
new2.17 KB

Here we go, contributors list based on all nodes tagged with 'phpunit initiative' and that had a commit in the git log. Distilled user names from the commit messages and used the API to match those to UIDs.

Some people have changed their user name, or are gone from d.o :(

I think we can find most of the people that changed name,

xjm’s picture

Title: Remove the phpunit initiative from MAINTAINERS.txt » The PHPUnit Initiative is complete!
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs DA engineering feedback

That's fantastic, thanks @Lendude!

Here's that list as a string:

dawehner, alexpott, michielnugter, naveenvalecha, Jo Fitzgerald, vaplas, ApacheEx, Mile23, borisson_, martin107, Wim Leers, jibran, GoZ, andypost, larowlan, nlisgo, jonathan1055, klausi, mpdonadio, claudiu.cristea, scuba_fly, Manuel Garcia, dagmar, vijaycs85, mondrake, Mixologic, Gábor Hojtsy, Berdir, xjm, boaloysius, Tessa Bakker, zviryatko, ziomizar, navneet0693, phenaproxima, snetcher, mglaman, yogeshmpawar, longwave, Dinesh18, catch, cspitzlay, zaporylie, hchonov, impalash, pasan.gamage, joachim, RytoEX, Meenakshi Gupta, shashikant_chauhan, nginex, justinlevi, tstoeckler, jhodgdon, proeung, Abhijith S, kostyashupenko, anmolgoyal74, sulfikar_s, mherchel, Spokje, scott_euser, nnevill, Utkarsh_Mishra, saurabh.tripathi.cs, Hardik_Patel_12, Krzysztof Domański, eliclaggett, roderik, msankhala, jhedstrom, pritish.kumar, NickWilde, babruix, m1r1k, tim.plunkett, ceardach, voleger, markdorison, dcam, MerryHamster, bapi_22, dan2k3k4, Pavan B S, brentgees, tanmayk, lomasr, bircher, hswong3i, legovaer, jmuzz, nuez, mkalkbrenner, gaurav.kapoor, Antonnavi, IRuslan, zahord, tameeshb, Mac_Weber, Ujin, quietone, maxocub, tar_inet, mohit1604, marcoscano, wengerk, sun, blazey, himanshu-dixit, esoteric1, droplet, cilefen, DuneBL

Also, making a better issue title for the log. :)

I'll reach out to infra and ask them if there's a way to do this bulk-crediting without a repeat of the D8MI situation.

gábor hojtsy’s picture

gábor hojtsy’s picture

Gábor Hojtsy credited GoZ.

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

Processed all credits up to tstoeckler. Only vaplas is missing (a missing user now unfortunately). This was roughly half the credits. I think we should be fine doing the other half sometime later and then closing this. Congrats to everyone notified so far :)

naveenvalecha’s picture

Yay, congrats everyone!

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

Gábor Hojtsy credited sun.

gábor hojtsy’s picture

gábor hojtsy’s picture

gábor hojtsy’s picture

Issue tags: -Needs DA engineering feedback

Thanks all for your hard work and congrats all! I added all users listed in #19 that are still on drupal.org following DA engineering feedback to go ahead.

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 24dbbbc108 to 9.2.x and 24f3a9492e to 9.1.x. Thanks!

  • alexpott committed 24dbbbc on 9.2.x
    Issue #3038234 by Lendude, Gábor Hojtsy, alexpott, xjm, naveenvalecha,...

  • alexpott committed 24f3a94 on 9.1.x
    Issue #3038234 by Lendude, Gábor Hojtsy, alexpott, xjm, naveenvalecha,...
alexpott’s picture

Issue summary: View changes
lendude’s picture

Just to be sure everybody gets it, I quote from the IS:

a big thank you to all involved, your contributions have been amazing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.