Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Jan 2017 at 07:38 UTC
Updated:
26 Feb 2017 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jeetendrakumar commentedComment #3
jeetendrakumar commentedComment #4
jeetendrakumar commentedComment #5
jeetendrakumar commentedComment #6
PA robot commentedProject 1: https://www.drupal.org/node/2843801
Project 2: https://www.drupal.org/node/2843800
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
jeetendrakumar commentedComment #8
visabhishek commented@jeetendrakumar : Please read https://www.drupal.org/node/2843800#comment-11869726
Comment #9
jeetendrakumar commented@Visabhishek,
I have closed other project and enable it for review.
Comment #10
visabhishek commented@jeetendrakumar : OK, Then Please update the git clone url for non-maintainer in issue summery page.
Comment #11
jeetendrakumar commented@visabhishek: On which project?
Comment #12
visabhishek commentedOk i am updating the URL for you. (https://www.drupal.org/node/2843800/revisions/view/10296053/10296081)
git clone --branch 7.x-1.x jeetendrakumar@git.drupal.org:sandbox/jeetendrakumar/2841270.git taxonomy_multi_delete_termsTO
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/jeetendrakumar/2841270.git taxonomy_multi_delete_termsComment #13
jeetendrakumar commentedThanks visabhishek :)
Comment #14
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #15
abhisaknigam commentedWhen i go to the list term page > there is displaying option "Reset to alphabetical" > when go there it is showing the delete option and design distorted on this page
Comment #16
abhisaknigam commentedWhen i go to the list term page > there is displaying option "Reset to alphabetical" > when go there it is showing the delete option and design distorted on this page
Comment #17
jeetendrakumar commentedHi abhisaknigam,
I have solved this issue.
Comment #18
deepanker_bhalla commentedHi,
Gr8. Working fine for me.
Comment #19
sanjay chauhan commentedHi @jeetendrakumar,
It seems that module is very light-weighted and easy to use. I have 2 concern here:
What you have to do is the following:
is there any difference?
Thanks,
Sanjay Chauhan
Comment #20
jeetendrakumar commented@Sanjay Chauhan
There are some following features of this module:
1. Light weighted and easy to use.
2. There are no need to make any configuration in Drupal to delete taxonomy terms (as Admin Views with VBO ).
3. You can delete multiple and all taxonomy terms easily.
Comment #21
abhisaknigam commentedComment #22
poojasharmaece commentedI am getting some unexpected result on "admin/structure/taxonomy/tags" page
Please see the attached screenshot
1: Normal page
2: After enabling the "[D7] Taxonomy Multi-delete Terms" module
Please check and Fix.
Comment #23
jeetendrakumar commentedHello @poojasharmaece
Thanks for review this project.
I have fixed this issue. Please verify.
Comment #24
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxjeetendrakumar284127...
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #25
jeetendrakumar commentedI didn't found any error.
Please check following URL:
https://pareview.sh/node/840
Comment #26
deepanker_bhalla commentedI have tested and found no issues. It's really very good module to use even its light weighted module and easy to use.
Comment #27
poojasharmaece commentedI tested the module , its working fine for me.
Only one issue i find
While we are deleting any term, we have a confirmation box "Are you sure you want to delete the term ?"
But using this module we dont have any confirmation page. So i think its a "Security Issue".
Comment #28
jeetendrakumar commentedHello @poojasharmaece
I have added conformation page. Please verify and change the status RTBC ;)
Comment #29
jeetendrakumar commentedComment #30
kumaratulesh commentedI have tested this module manually and it's working fine for me.
Comment #31
jeetendrakumar commentedComment #32
jeetendrakumar commentedComment #33
klausiFixing tags.
You have not listed 3 reviews in the issue summary, please complete that first. See https://www.drupal.org/node/1975228
And please don't remove the security tag, we keep that for statistics and to show examples of security problems.
Comment #34
jeetendrakumar commentedComment #35
jeetendrakumar commentedComment #36
poojasharmaece commentedHi jeetendrakumar,
Now confirmation page is fine and Terms are deleting perfectly.
Some suggestions are :
1: Term delete confirmation message is not complete. Here so many term names are missing. I am attaching some screenshot. Please check once.
2: Confirmation page : Please make it clean, we have some unnecessary data here.
Thanks again.
Comment #37
jeetendrakumar commentedHello poojasharmaece,
Thanks for review my project :)
1. I have changed delete conformation message.
2. Confirmation page: I am following "Reset to alphabetical" same layout for this page.
Comment #38
jeetendrakumar commentedComment #39
klausifixing tags.
Comment #40
visabhishek commentedReview of the 7.x-1.x branch (commit dae6025):
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
As suggested by poojasharmaece following message is irrelevant on delete confirmation page :
Tags contains terms grouped under parent terms. You can reorganize the terms in Tags using their drag-and-drop handles.You can remove or change the message.Otherwise all looks good for me.
Thanks for your contribution, jeetendrakumar!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #41
klausiAssigning issue credits.