Overview:
Fluidproject's UI Options provides accessibility options for users to modify a page's font size, line height, font style, contrast, and link style. The changes are retained using cookies.
This module integrates the library into Drupal's non-admin pages. I couldn't find any other modules that integrate this framework or similar accessibility modules.
Demo:
http://fluidproject.org
Requirements:
- Libraries API
- Fluidproject's Infusion /src/components, lib, and framework folders copied to sites/all/libraries/fluid https://github.com/fluid-project/infusion
- jQuery version 1.7 or higher. You can use the jquery_update module to do this
Limitations:
- Internationalization is not done through the Drupal interface but through JSON files within the module folder. More on this in the README.
- It has been tested with the most popular themes successfully. Some themes (i.e. Bootstrap) need additional CSS in order for font-sizing or line heights to work (setting percentage or EM values).
- The contrast settings do not work for elements that use CSS gradients.
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ashopin/2385899.git fluidproject_ui_options
https://www.drupal.org/sandbox/ashopin/2385899
Reviewed the following projects:
Comment | File | Size | Author |
---|---|---|---|
#17 | coder.txt | 38.19 KB | naveenvalecha |
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxashopin2385899git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
ashopin CreditAttribution: ashopin commentedI have addressed most of the issues.
Thanks.
Comment #3
Oleks Iv CreditAttribution: Oleks Iv commentedHi, ashopin
Automated Review
Here there are still errors and warnings http://pareview.sh/pareview/httpgitdrupalorgsandboxashopin2385899git
Manual Review
Pay attention on point 6.
Use hook_theme() + template file for it.
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #4
Oleks Iv CreditAttribution: Oleks Iv commentedComment #5
ashopin CreditAttribution: ashopin commented@alexsergivan
Thank you for the detailed review.
Automated Review: I addressed the issues the found that I could.
Licensing: Is this referring to the 'Enactors.css'? That is part of the 3rd party framework I'm integrating, it is minified because that's how it's supplied.
README: I rewrote it as per one of the example layouts provided.
Thanks again.
Comment #6
prakhyatgailani CreditAttribution: prakhyatgailani commentedI have followed instructions enabled the module and after creating a basic page, I am unable to to find the "+" as explained in the top left corner.
Moreover in the second step after hitting the URL "https://github.com/fluid-project/infusion/tree/" , getting the 404 error.
Comment #7
prakhyatgailani CreditAttribution: prakhyatgailani commentedComment #8
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2433209
Project 2: https://www.drupal.org/node/2433171
Project 3: https://www.drupal.org/node/2395035
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
ashopin CreditAttribution: ashopin commentedComment #10
ashopin CreditAttribution: ashopin commentedComment #11
ashopin CreditAttribution: ashopin commented@Prakhyat Gailani
I've updated the README so that that link works. I installed the module from scratch and realized that the jQuery version needs to be at least 1.7. I updated the project page and the README to reflect this.
Thanks.
Comment #12
PA robot CreditAttribution: PA robot commentedProject 1: https://www.drupal.org/node/2395035
Project 2: https://www.drupal.org/node/2433209
Project 3: https://www.drupal.org/node/2433171
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #13
ashopin CreditAttribution: ashopin commentedClosed my other submissions, misunderstood the "Multiple Applications" bot.
Comment #14
TheSteveLavigne CreditAttribution: TheSteveLavigne commentedComment #15
ashopin CreditAttribution: ashopin commentedComment #16
ashopin CreditAttribution: ashopin commentedComment #17
naveenvalechaAutomated Review :
Need to fix these. http://pareview.sh/pareview/httpgitdrupalorgsandboxashopin2385899git
Also file attached.
Manual Review :
sites/all/modules/fluid/messages/
,.... in the file.Pass the paths of module path into javascript by passing the values.Removing review bonus.Please get another review bonus for 2nd review.
Comment #18
ashopin CreditAttribution: ashopin commentedThank you for the review.
Comment #19
naveenvalechaThe above are not blockers.
Assigning to er.pushpinderrana for next review if he has time.
Comment #20
ashopin CreditAttribution: ashopin commentedThank you again!
$page['page_top']['fluid']['#attached']['js']
Comment #21
ashopin CreditAttribution: ashopin commentedComment #22
ashopin CreditAttribution: ashopin commentedComment #23
klausimanual review:
Since this was RTBC already and Naveen also thinks it's fine now I think we can directly approve, so ...
Thanks for your contribution, ashopin!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #24
ashopin CreditAttribution: ashopin commentedThank you, klausi!
I've implemented 1, 2, and 5. I will update the other items shortly.