D7 GWT-Drupal

Timeout when invoking pareview.sh for http://git.drupal.org/sandbox/voj/2435281.git at http://pareview.sh/pareview/httpgitdrupalorgsandboxvoj2435281git

Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi voj,

Can you please add a git clone link to your issue summary so we can grab a copy of the code base to evaluate it for full project status.

Like here: https://www.drupal.org/node/2458731

Thanks.

Hello,

You are missing the git pull instructions:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/voj/2435281.git gwt_drupal
cd gwt_drupal

Theme Structure

1. Your .info is missing the 'core' attribute. I had to add it to turn your theme on.
2. You are not following Drupal's rules when it comes to 3rd party libraries. You are including a version of jQuery (!!!) and a responsive framework (!) in your theme. These are big no-no's. You can use jquery_update to include an updated version of jQuery and the libraries framework to include the foundation framework. This theme will not be approved until this is done.
3. You are pulling in content in the footer through a JS file. This is not good. The user cannot change this information. Please move this into your theme so it's rendered there and so that it's user editable.
4. You are missing the README file.

@voj Adding your git information :)

Hi voj,

Quick Manual review:
Remove the commented code from theme-settings.php line number:
24-31 line number just an eaxmple
212-229 if its of no use.
I dont think main.css.dist is required in /css folder.

Thanks,
nitvirus.

Adding a screenshot : upon going to appearance page i am not able to select the theme,
saying this version is not compatible with drupal 7.x

Manual review of code

1. Define core = 7.x in Info file to remove error that @nitvirus have pointed out.
2. @file doc is missing in theme-settings.php
3. Please don't add drupal_add_js in theme.settings.php. check best practices
4. Please add README.txt file in theme.
5. I think this code snippet could be removed from page.tpl.php

<?php
  /**
   * mandatory region
   */
?>

6. Query: If you have same structure of templates of all block footers then why tpl's for all blocks ?

Also Please add review bonus.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.