Hi,
I would like to apply for a full project for the theme GWT-Drupal theme. The theme's main function is to provide one solution that enables the Philippines Government Websites to implement Administrative Order No. AO39 without having them to develop their own or outsource the development for the compliance.
The main objective of why do we need to publish the theme in the drupal.org is to allow automatic updates coming from the website itself. (using cron) So that the users will be able to update easily without having to download--upload--install process. Just a one click install and it will be updated.
This is an initiative of iGovPhil Project of ICTO-DOST which is a Philippines government project.
The theme is actively developed in github and is currently being used by some of the website portals. With a support from iGovPhil.
For issues and concerns you may request an issue, pull request in github, or email us at gwtsupport@i.gov.ph
Git Instructions :
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/voj/2435281.git gwt_drupal
cd gwt_drupal
Comment | File | Size | Author |
---|---|---|---|
#7 | Screenshot from 2015-04-13 11:57:26.png | 182.85 KB | nitvirus |
Comments
Comment #1
voj CreditAttribution: voj commentedComment #2
PA robot CreditAttribution: PA robot commentedTimeout when invoking pareview.sh for http://git.drupal.org/sandbox/voj/2435281.git at http://pareview.sh/pareview/httpgitdrupalorgsandboxvoj2435281git
Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
markconroy CreditAttribution: markconroy at Annertech commentedHi voj,
Can you please add a git clone link to your issue summary so we can grab a copy of the code base to evaluate it for full project status.
Like here: https://www.drupal.org/node/2458731
Thanks.
Comment #4
ashopin CreditAttribution: ashopin commentedHello,
You are missing the git pull instructions:
Theme Structure
Comment #5
Manjit.Singh@voj Adding your git information :)
Comment #6
nitvirus CreditAttribution: nitvirus commentedHi voj,
Quick Manual review:
Remove the commented code from theme-settings.php line number:
24-31 line number just an eaxmple
212-229 if its of no use.
I dont think main.css.dist is required in /css folder.
Thanks,
nitvirus.
Comment #7
nitvirus CreditAttribution: nitvirus commentedAdding a screenshot : upon going to appearance page i am not able to select the theme,
saying this version is not compatible with drupal 7.x
Comment #8
Manjit.SinghManual review of code
1. Define
core = 7.x
in Info file to remove error that @nitvirus have pointed out.2. @file doc is missing in
theme-settings.php
3. Please don't add
drupal_add_js
intheme.settings.php
. check best practices4. Please add README.txt file in theme.
5. I think this code snippet could be removed from page.tpl.php
6. Query: If you have same structure of templates of all block footers then why tpl's for all blocks ?
Also Please add review bonus.
Comment #9
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.