[D7] Beauty Theme

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxwebtitan2358895git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,
you should check your beauty_shop.info file, line 5: [code] screenshot = screenshot.png [/code]
In the root of your theme you have a screenshot.jpg, so in the appearence page won't appear any screenshot.

Your screenshot.jpg is 219x219 pixel, please see the screenshot guidelines for more information (https://www.drupal.org/node/647754).
Looking this guidelines i think you should modify it for 4:3 ratio (294x219 pixel).

You also should read module documentation guidelines ( https://www.drupal.org/node/161085 ) and look at README-template here: https://www.drupal.org/node/2181737 , after reading please try to make your readme.txt more compliant.

P.S. thanks for your theme ;-)

Hi webtitan,

Manual Review
1) Add clone URL in issue description

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/webtitan/2358895.git beauty_shop

2) Missing site name & caption.

<div>
	<a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>"><?php print $site_name; ?></a>
	<div id="site-description"><?php print $site_slogan; ?></div>
<div>

3) Social Media
- icon not aligned well.
- Hard coded URL - You should not hard code social media URL.
4) Mobile number is hard coded - Do not hard code content in template.

Thanks

Hi webtitan,
Your theme is very beautiful.

I have reviewed it and got an error. It is mentioned below:
Strict warning: Only variables should be passed by reference in include() (line 41 of \themes\beauty_shop\page.tpl.php).
Instead of:
print render(module_invoke('search', 'block_view', 'search'));
Replace it with:

          $block = module_invoke('search', 'block_view', 'search');
          print render($block); 

Your git info is incorrect. This is what I used to pull your theme:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/webtitan/2358895.git beauty_shop
cd beauty_shop

Theme Structure

1. I recommend you use a /templates folder for your *.tpl.php files to keep a clean theme folder structure.
2. You are adding an external JS file in your template.php. I believe you should investigate using libraries instead. On closed networks or networks with high security, retrieving external files will create issues.
3. You have hard-coded strings and links in your page.tpl.php. This is not best practice because most users can't update the theme. You should either create variables that are set in the theme-settings or a custom module. Regardless, all strings should be wrapped in the t() function in order for it to be translatable.
4. block.tpl.php, line 13 has an opening span and a closing

   . This needs to be fixed.

5. back-to-top.js, it is recommended to use the Drupal javascript structure: https://www.drupal.org/node/304258

@webtitan Updating your git information :)

Hi Webtitan,

Here is my review:
1. Screenshot is not coming as suggested by @Skin, you would change the extension in .info file or the screenshot file upon you.
2. Upon enabling the theme I am getting a warning,Strict warning: Only variables should be passed by reference in include() (line 41 of /var/www/html/drupal/sites/all/themes/beauty_shop/page--front.tpl.php)., see attached screenshot.
3. The search block in first sidebar has un-aligned submit button (class -button-search). It is being hidden/ overlapped , please see the second screenshot.

Thanks,
Nitish

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2662738

Project 2: https://www.drupal.org/node/2369009

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.