Our current drupal_build_css_cache() and drupal_build_js_cache() logic works like this:
* There's a request to the page.
* If the bundle doesn't already exists, drupal_build_css/js_cache() will generate and save all it.
* After this initial request is finished, the browser the requests the saved files as normal and serves the page.
There are multiple issues with this, most of which is documented at- to summarize:
* There is no logic in HEAD to prevent race conditions where the same file could be built multiple times by different requests to PHP, if you have numerous bundles and high traffic this can cause i/o issues.
* On an i/o constrained setup, I'm seeing this process take around 400ms (for ten bundles in total between css and js), that's around 30% of the entire request as measured by webgrind.
* Attempts to introduce locking can lock every PHP request to the site - for example if a bundle is served on a large number of pages that all get requested during a cold start situation, and they get stuck in lock_wait() for the first request to build and save the file, so while doing this can reduce the i/o impact, it can still take a site down due to hanging apache processes.
* Every bundle saved is also a call to variable_set(), which has its own issues with locking and race conditions - see and for attempts to solve this.
* Register routes for files/css and files/js
* construct the aggregate URLs by using a list of libraries
* When the request comes in, the libraries can be aggregated together, written to a file, then just for that request the file gets served from the route.
* The main page request then only needs to generate the link, there is no need to check either storage or the filesystem to see if an aggregate exists.
* In the case of stampede, we can check file_exists() both before building the file, and before trying to actually save it. As soon as the file is saved, subsequent requests won't be hitting PHP anyway ( afaik image module doesn't do this at the moment, but it probably could)
|FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1014086-80-css-imagecache.patch. Unable to apply patch. See the log in the details link for more information.|
|FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1014086-77-css-imagecache.patch. Unable to apply patch. See the log in the details link for more information.|
|PASSED: [[SimpleTest]]: [MySQL] 35,378 pass(es).|
|PASSED: [[SimpleTest]]: [MySQL] 35,631 pass(es).|
|PASSED: [[SimpleTest]]: [MySQL] 29,765 pass(es).|