Problem/Motivation

All code supposed for removal in 11.x should be sleaned here in system module

Steps to reproduce

git grep '@deprecated' -- core/modules/system/
git grep 'in drupal:11' -- core/modules/system/
git grep 'from drupal:11' -- core/modules/system/

Proposed resolution

Remove deprecated code (ensure drupal:12 changes will stay)

Remaining tasks

Implement
Review

User interface changes

NA

API changes

Deprecated code is removed

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3425419

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

andypost opened merge request !6897

andypost’s picture

andypost
he/him
Primary language Russian
commented

'The system.performance.stale_file_threshold config key is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/3301744

needs special follow-up

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Ready for review

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Searched systems folder for

@deprecated
1 in deprecated_test.module = non issue
1 instance in system.install for something removed in D12 = non issue

Searching for "from drupal:11" found 2 instances I believe that are needed.
system.schema.yml stale_file_threshold is deprecated
Deprecated.php also

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#3410301: Deprecate system.performance stale_file_threshold

removed schema and stale_file_threshold with asset-optimizers after #3410301: Deprecate system.performance stale_file_threshold

Deprecated.php should stay as this is testing element deprecation, ref #3067580: Deprecate the AJAX RenderElement

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3038971: Move system_get_module_admin_tasks() into a service and deprecate it, +#1014086: Stampedes and cold cache performance issues with css/js aggregation, +#2921810: Allow TimestampFormatter to show as a fully cacheable time difference with JS, +#3301573: Remove the aggregate stale file threshold and state entry, +#3358336: Deprecate _drupal_flush_css_js() and create a new AssetQueryString cache service, +#3335768: Manually clear cache keys from plugin managers with finite variations instead of using cache tags, +#3112298: Replace REQUEST_TIME in classes with direct container access, +#2662330: Machine name generation is way too slow, +#3316923: Sort out more driver specific database kernel tests, +#3223205: deprecate system_retrieve_file() without replacement, +#3020455: Deprecate system_time_zones() and move to TimeZoneFormHelper

Added related to deprecation issues

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Appears all removals have been done for the system module.

  • catch committed ad62036a on 11.x 
    Issue #3425419 by andypost, smustgrave: [11.x] Remove deprecated code...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Had to think a bit about the update path testing and presave removals, but on balance I think this makes sense - it will allow the actual update removals and database fixture regeneration to happen without lots of other changes bundled in.

Committed/pushed to 11.x, thanks!

andypost closed merge request !6897

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 11.0.x-dev

Update version to the branch this applies to.