Problem/Motivation

Follow-up to #3301573: Remove the aggregate stale file threshold and state entry. If sites don't export their config after the updates that delete this key, they'll then get error messages from config validation.

Steps to reproduce

NA

Proposed resolution

So we should add it the stale_file_threshold key back to the schema, deprecated to 10.x, then actually remove it in 11.x

Remaining tasks

Review

User interface changes

NA

API changes

Add back stale_file_threshold

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3410301

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Active » Needs review

Something like this.

catch opened merge request !5918

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
CreditAttribution: dqd as a volunteer and at MAROQQO studios commented
Issue summary: View changes
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
CreditAttribution: dqd as a volunteer and at MAROQQO studios commented

Thanks for creating the issue @catch!

Link to the initial report & follow up thread and findings on Slack where this has been discussed: https://drupal.slack.com/archives/C1BMUQ9U6/p1703153827992839 (Thanks to @WimLeers for his quick reaction on my report and his immediate findings and links to the causes)

In the previous mentioned discussion the following system.performance keys have been error reported on screen or noted to probably become problematic while saving admin performance cache settings:

cache:
  page:
    use_internal: false

response:
  ...

stale_file_threshold: ...

So, follow up readers who need to fix that manually for now: check your system.performance config by running drush cget system.performance In case you find obosolete left-over keys (read Wim's and my notes and links in the Slack chat above), in our case like cache: page: use_internal or stale_file_threshold and response you can remove them with 

drush cdel system.performance cache.page.use_internal

drush cdel system.performance stale_file_threshold

drush cdel system.performance response

etc.

(note the dot to target sub ordinated keys)

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Not sure what's suppose to be reviewed.

Can the issue summary be completed. If something is deprecated is the CR attached to another ticket?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes
Status: Needs work » Needs review

@smustgrave the CR is attached to #3301573: Remove the aggregate stale file threshold and state entry, what's deprecated is the config schema key.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thanks in that case LGTM.

larowlan credited Wim Leers.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Issue credits

larowlan closed merge request !5918

  • larowlan committed 9fb6b609 on 10.2.x 
    Issue #3410301 by catch, diqidoq, Wim Leers: Deprecate system....

  • larowlan committed d8761276 on 11.x 
    Issue #3410301 by catch, diqidoq, Wim Leers: Deprecate system....
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and backported to 10.2.x

Nice work all 💪

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: wim leers at Acquia commented
Issue tags: +Configuration schema, +validation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.