[D7] On page search

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2834321

Project 2: https://www.drupal.org/node/2828431

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I have installed and enabled the module on a Drupal 7 site. Check the below issue

Issues:

1. I have entered the word 'arcu' in the text field, but it will be highlighed all the word started to 'a'. Ex 'age', 'Add Content', 'avigation' ect. Refer screen shot(ops-image1.png).

2. If I entered more than one character into the text field I received the 'Uncaught ReferenceError: new_node is not defined' error. Refer screen shot(ops-image1.png).

3. I updated the jQuery version above 1.8, the script not working properly. I received 'TypeError: jQuery(...).live is not a function' error. Refer screen shot(ops-image2.png).

Hi,

I have tested this module and its working fine as per the feature provided. but I think the search feature is a site wide requirement if used in any project, so the js included in block view using drupal_add_js() can be moved to ops.info file.

But again in case any site want it on specific pages than the current implementation is absolutely correct.

Moving this project to RTBC

Thanks
anup.singh

Hi rajveergang,

While reviewing I found one issue related to jquery "Uncaught TypeError: jQuery(...).live is not a function" in ops-search.js, please fix this.

More detail.
.live() method is deprecated. Use .on() to attach event handlers. Users of older versions of jQuery should use .delegate() in preference to .live().

Thanks
anup.singh

Hi rajveergang,
Just reviewed and now jQuery error is fixed.
Thanks

Hello,

Here is my review:

Automated Review
No issues found when testing via pareview

https://pareview.sh/node/348

Manual Review
Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follow the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Thanks.

Removing review bonus tag, you have not done all manual reviews, you just repeated the output of an automated review tool. Make sure to read through the source code of the other projects as requested on the review bonus page https://www.drupal.org/node/1975228

When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

Below are my manual review:

1. Use module name as prefix in element id, class "highlight" and variable color_hex_value for avoid conflict with others elements, classes and variables;

2. Maybe in ops_return_background_color function provide default value to variable_get function instead of validate if is empty, example variable_get('color_hex_value', '#fff34d');

3.In ops_setting_form_validate function you overwrite the value if empty, maybe notificate user that if value is empty one default value is set.

What do you think?

Your default color not being saved, you need put the value into $form_state['values']['ops_color_hex_value'].

  $form_state['values']['ops_color_hex_value'] = $color;

And use placeholder in function t.

  drupal_set_message(t("Default color @color is set now for background.", array('@color' => $color)));

thanks

Review of Commit 75928cf on 7.x-1.x

1: No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

2: Please update readme files as https://www.drupal.org/node/2181737

Thanks for your contribution, rajveergang!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.