[D7] Node Alias History

Hi , agautam ,

Below are my manual review

Manual review of the 7.x-1.x branch:

Coding style issues:

Implements hook_help() in .module
line 171 , unused $data variable node_alise_history.module
line 203 , unused variable $num_of_results node_alise_history.module

variable initialisation should be on first on every function.

example for function get_node_alias_history_rows() should be like

$data = array();
$html = '';
$rows = array();
$nid = isset($_GET['nid']) ? $_GET['nid'] : '';
$alias = isset($_GET['alias']) ? $_GET['alias'] : '';

Readme template should be follow. Readme file should be more descriptive.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxankushgautm2843419git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please add validation in search form for node , as i am entering text value then form got submitted

Hi Ankush ,

Below are my manual reviews.

[+]
Goto admin/config/search/node-alias-history
press reset button (with empty nid)
error is coming Please enter only numeric value.

[+]
In your function node_alias_history_rows() , before printing data in table write secure code form preventing cross site scripting.

[+]
you should use rowCount() in your function function node_alias_history_existance($nid, $alias) for counting the result. As of now you are selecting all the rows then couting. It doesnt sence here.

Hi,

File: node_alias_history.module:-

1. Line number 53 and 64
node_alias_history_node_insert
node_alias_history_node_update
We can use a generic function instead of these two functions,hence reducing code.
2. Line 103 and 104
We can directly return this variable $result->rowCount() in isset.
3. Line 118,125,etc...
We can use single quote instead of double.
4.Line 181,182, etc
We can use drupal_get_query_parameters instead of $_GET if possible.
5. Line 216 and 218
We can remove check_plain doesn’t from nid and alias.
6. Spelling mistake existance in node_alias_history_existance (existence)
7. Line number : 75, 97, etc
missing comment documentation for param.

fixing tags.

Hi @agautam
Module is working as expected. I have checked your module on pareview.sh (https://pareview.sh/node/947)

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements]

Coding style & Drupal API usage

No major issues found. Code looks good to me both functionality wise and code vise. Didn't find any issue on pareview.sh (https://pareview.sh/node/947)

This review uses the Project Application Review Template.Code looks good.

@manav : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Hi Ankush

File: node_alias_history.module:-

Line no 117
There are spelling mistake (Search Alies) and missing t() function.

As a suggestion-
You can add sorting on time stamp basis

@agautam,

Suggestions:
1. Please add some messages when we click on submit or reset form button.
2. reset button should be visible when we search any alias.

Rest of functionality is working fine for me.

adding project page.

manual review:

1. "#comment work on issue" is not a good git commit message. Please see https://www.drupal.org/node/52287 for your future commit messages.
2. node_alias_history_form_validate(): instead of this custom validation function you should use #element_validate on teh form element with element_validate_integer_positive. See https://api.drupal.org/api/drupal/developer%21topics%21forms_api_referen...
3. node_alias_history_rows(): do not call theme() here, just return a nested render array. Drupal core will render it later for you and other module can easily change it.
4. node_alias_history_rows(): doc block is wrong, this is not a hook but a page callback? See https://www.drupal.org/docs/develop/coding-standards/api-documentation-a... Please check all your doc blocks of non hook implementations. Don't repeat the function name. You should describe briefly what the function is and does.
5. node_alias_history_rows(): this is vulnerable to XSS exploits. If I enter <script>alert('XSS');</script> as path alias for a node then this table show a nasty javascript popup. You need to sanitize user provided text before printing, same as for the node title. Make sure to read https://www.drupal.org/node/28984 again. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Hi agautam,
Please take another review bonus for next git admin review.

@visabhishek: having 6 reviews is enough to keep the review bonus tag :) See https://www.drupal.org/node/1975228

@klausi : Thanks for correcting me.

Fix error at line 144

Hi @agautam,
very well, I tested the module is doing his job, a great way to track the changes of alias.

manual review:

1. "#comment Issue #40 by ankush : Fixed issue": is not a good git commit message. You should describe what you changed.
2. node_alias_history_form(): doc block is wrong, you are just repeating the function name. This is a form constructor, right? See https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...
3. node_alias_history_form(): do not call drupal_render() here, just return a nested render array. Instead of #markup you use the theme/template function name. See also https://www.drupal.org/node/930760

Otherwise looks good to me.

Thanks for your contribution, Ankush!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.