[D7] Email Field Subscribe

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxmonstrfolk2847908git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi monstrfolk,

Below is my manual review .

Please change

/**
 * Implements hook_entity_insert().
 */

to

/**
 * Implements hook_entity_delete().
 */

on line 166

Hi monstrfolk,

please add hook_help in module file.

Automated Review

[Best practice issues identified by Automated pareview
FILE: /root/repos/pareviewsh/pareview_temp/email_subscriptions.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
13 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing parentheses
15 | ERROR | [x] Concat operator must be surrounded by a single space
18 | ERROR | [x] Concat operator must be surrounded by a single space
18 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (+) Release blocker
2. Gettiing a notice message: kindly check that as well
   Notice: Undefined property: stdClass::$type in _email_subscriptions_update_subscriptions() (line 199 of /var/www/html/drupal/sites/all/modules/email_subscription/email_subscriptions.module).
3. ...]

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Secure code

Follow the template

Please take a moment to make your project page follow tips for a great project page.

Follow the Project page template Please follow the standard Project page templete

Go through Tips for ensuring a smooth reviewFolow the few guidlines and template given

Go through README TemplateFolow the few guidlines and template given

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@Devaraj johnson: looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Sorry Guys just look back, Looks good for me moving to RTBC, Dint find any application blocker, Also we will wait to hear from the Git administrator as well :)

Also @klausi I am in the learning curve in the Review process :), Kindly guide me in the review process :)

@monstrfolk Kindly look in to this issue and validate the variable,

Notice: Undefined property: stdClass::$type in _email_subscriptions_update_subscriptions() (line 199 of /var/www/html/drupal7example/sites/all/modules/email_subscription/email_subscriptions.module).

Hi monstrfolk,

We have to wait for the git administrator to review and approve your project to full project.

manual review:

• email_subscriptions_help(): no need to call filter_xss_admin() or check_plain() here since no user provided text is involved. The contents of the README was written by yourself, so we can consider that trusted data.

Otherwise looks good to me.

Thanks for your contribution, monstrfolk!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Assigning credits.