[D8] Autocomplete Node Search

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi sugandhkhanna2,

Below are my manual review

Manual review of the 8.x-1.x branch:

1 : path -> /src/controller/AutocompleteQueryHandler.php

Please add t() function on line 41 $matches = array('Result not found.');

On line 36 which is $alias = (strlen($alias) > 23) ? substr($alias, 0, 20) . '...' :
Please take as constant and make it configurable.

2: path -> /src/plugin/block/ANSBlock.php

Please provide proper description of block.

Hi @sugandhkhanna2,

This module is not working for me. I am not able to find "node:title" and whenever i am trying to click on submit button it throws an error for me(Kindly check the screenshot for reference).

Manual Review:

• Whenever i try to access /nodename/autocomplete/multiple page i get a blank page. please let me know if i am missing something
• It is a good practice to add hook_help in .module file
• I would suggest you to add configure in .info.yml file

ANSBlock.php

37

  /**
   * {@inheritdoc}
   */
  public function validateForm(array &$form, FormStateInterface $form_state) {

  }

I would recommend no need to write this function untill you don't want to do some validation from your end.

• Try to use dependency injection (3rd screenshot is related to it.)

AutocompleteQueryHandler.php

27

     $nids = \Drupal::entityQuery('node')
    

ANSBlock.php

22

    $builtForm = \Drupal::formBuilder()->getForm('Drupal\autocomplete_node_search\Form\AutocompleteNodeSearch');
   

Recommendation: 'formBuilder' service should be injected.

@sugandhkhanna2 : Please add the project page URL and git clone command in the issue summary.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

I have done manual review of your code and find one issue based on below scenario:

1) First create a node title like "Test:12"
2) Search this node in your block (see screenshot: case_1.png)
3) Hit enter/submit button you will get the error (see screenshot: case_2.png)

Solution: You will have to change the logic of code "explode(':', $form_data);" under submitForm function.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Review of the 8.x-1.x branch (commit 0a18836):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...ew_temp/autocomplete_node_search/src/Form/AutocompleteNodeSearch.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   42 | WARNING | node_load_multiple() calls should be avoided in classes,
      |         | use dependency injection and the "entity_type.manager"
      |         | service instead
  --------------------------------------------------------------------------
  
  Time: 40ms; Memory: 4Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. The git repository contains an additional folder "autocomplete_node_search" which should be removed. The files should be in the repository root.
2. autocomplete_node_search.info.yml: dependency to the node module is missing, because your module will not work without it, right?
3. autocomplete_node_search_help(): all user facing text must run through t() for translation.
4. ANSBlock::build(): Do not hard-code class names in strings, use AutocompleteNodeSearch::class instead.
5. AutocompleteNodeSearch: the is form does not respect node access grants when performing the query. node_load_multiple() will load ALL nodes regardless of access, so that must not be used here. Use an entity query instead. "When adding a node listing to your module, be sure to use an entity query, which will add a tag of "node_access". This will allow modules dealing with node access to ensure only nodes to which the user has access are retrieved" from https://api.drupal.org/api/drupal/core!modules!node!node.module/group/no... . See also https://www.drupal.org/node/1827278 . This isa currently a security blocker. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi sugandhkhanna2,

I think you have solved all the issues described above by @klausi & I can not find any application blocker in your code.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Sorry, I forgot to click on "Save" after setting your account. Now you are a vetted user, and you can opt-in to the security advisory coverage.