Provides a social link field type. The module has possibility to customize form widget and form formatter. If field items count is limited then user can allow or deny to change social networks in entity create/edit form and possibility to change items order. In formatter display user can choose Font Awesome icons (Common/Square) or network names.

This module is based on Social Media Links Block, but here we can also add Social Link Field to any entity type.

Project page:
https://www.drupal.org/node/2863560

GIT clone command:
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/Romix/2863560.git social_link_field

Comments

Romixua created an issue. See original summary.

romixua’s picture

Assigned: romixua » Unassigned
PA robot’s picture

Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxRomix2863560git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

sugandhkhanna2’s picture

StatusFileSize
new164.38 KB

I have found few issues while reviewing code manually:
In file /src/Plugin/Field/FieldWidget/SocialLinkWidget.php
line no.: 55
You have used \Drupal::routeMatch()->getRouteName(); which should be avoided. Use dependency injection instead.

/src/Plugin/Field/FieldFormatter/SocialLinkFontAwesomeFormatter.php
line 73 | WARNING | Unused variable $delta.

social_link_field

Please fix pareview.sh reviews. https://pareview.sh/node/1455

romixua’s picture

Status: Needs work » Needs review
d.novikov’s picture

Status: Needs review » Needs work

Found a couple of issues:

  1. js/social-link-field-social-select.js.js has duplicate extension
  2. please use proper indentation in templates/social-link-field-formatter.html.twig
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.