Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Mar 2017 at 13:44 UTC
Updated:
29 Jun 2017 at 10:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
romixuaComment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxRomix2863560git
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
sugandhkhanna2 commentedI have found few issues while reviewing code manually:
In file /src/Plugin/Field/FieldWidget/SocialLinkWidget.php
line no.: 55
You have used
\Drupal::routeMatch()->getRouteName();which should be avoided. Use dependency injection instead./src/Plugin/Field/FieldFormatter/SocialLinkFontAwesomeFormatter.php
line 73 | WARNING | Unused variable $delta.
Please fix pareview.sh reviews. https://pareview.sh/node/1455
Comment #5
romixuaComment #6
d.novikov commentedFound a couple of issues:
js/social-link-field-social-select.js.jshas duplicate extensiontemplates/social-link-field-formatter.html.twigComment #7
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.