[D8] Norwegian ID Field

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxesolitos2859375git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi esolitos,

pareview is containing some errors and warning. Please fix them.
pareview: https://pareview.sh/node/1352

I installed the test and made a couple of tests with valid norwegian ids.

Automated Review

Although Pareview reports minor issues, I think it's just fine.
I also would prefer isValidNorwegianId() over isValidNorwegianID(), because the clean lower camelCase for Id's is used in Drupal 8 core. It also helps for consistency, when using Id in another context, like getIdFromSomewhere(), to clearly separate the word boundaries.

But that's just a tiny detail, so shouldn't block the application:

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

The code looks in general alright for me and makes uses DrupalAPI how it is intended.

Although it seems, that I identified an major issue in the number validation. I see a problem in

protected function isValidIndividualNum($individualNumber, $birthYear) {

When I use for example the number 311208945xx, which is a boy, who was born at 31.12.2008 fails. (You can use 2 random digits at the end, because it doesn't matter for that testcase)

The reason, that it fails, is that the function directly returns the result of the condition for a specific individual number range. As they are overlapping number ranges my case goes into

 elseif ($individualNumber >= 900 && $individualNumber <= 999) {
      return $birthYear >= 1940 && $birthYear <= 1999;
    }

and return false. Although my test individual number also works for the next elseif and would return true there.

elseif ($individualNumber >= 500 && $individualNumber <= 999) {
      return $birthYear >= 2000 && $birthYear <= 2039;
    }

Can you reproduce the error, or was I wrong with my manual testcase?

Thanks for solving the logical error in the module, it validates correct now. Perfect to have that proven by tests.

From my perspective the module looks ready to go now.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Assigning credits.