Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Image lazy load plugin to boost page load time and save bandwidth by removing: images, background-images, responsive images, iframes. Elements will load just when you reach the visible part of the screen, + an optional amount of pixels above and below the screen.
Settings of this module are in Configuration page.
Project page:
https://www.drupal.org/sandbox/zedna/2828013
GIT clone:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/zedna/2828013.git image_lazy_load
cd image_lazy_load
Comment | File | Size | Author |
---|---|---|---|
settings.png | 37.19 KB | zedna |
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
katerwater CreditAttribution: katerwater commentedComment #4
Jabastin Arul CreditAttribution: Jabastin Arul commentedPlease review your code on "https://pareview.sh" site. We found some issue in your code. Here I have attached the link for your error code.
https://pareview.sh/node/163
Comment #5
Jabastin Arul CreditAttribution: Jabastin Arul commentedComment #6
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
zedna CreditAttribution: zedna as a volunteer commentedThanks for your reviews, i´ve fixed the issues and according to Coder it should be OK.
Comment #8
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxzedna2828013git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
zedna CreditAttribution: zedna as a volunteer commentedRemoved all errors.
Comment #10
rajveergangwarHi,
1) Please create hook_help
2) Please create .install file to remove variables like : image_lazy_load_skip_parent
Comment #11
zedna CreditAttribution: zedna as a volunteer commentedThanks, i´ve added install and uninstall hooks.
Comment #12
vaibhavdev CreditAttribution: vaibhavdev commentedAutomated Review:
Review of the 7.x-1.x branch (commit a3437df):
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.
FILE: /root/repos/pareviewsh/pareview_temp/image_lazy_load.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
84 | WARNING | Do not use drupal_add_js() in hook_page_build(), use
| | #attached for CSS and JS on the $page render array
| | instead
94 | WARNING | Do not use drupal_add_js() in hook_page_build(), use
| | #attached for CSS and JS on the $page render array
| | instead
--------------------------------------------------------------------------
Time: 17ms; Memory: 4Mb
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
FILE: /root/repos/pareviewsh/pareview_temp/image_lazy_load.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
--------------------------------------------------------------------------
FILE: /root/repos/pareviewsh/pareview_temp/image_lazy_load.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
--------------------------------------------------------------------------
Manual Review:
Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt
No: Does not follow the guidelines of the template guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
There are errors:
1. In .info file the comment on line number 9 you have used is "Implementation of hook_install()", instead it should be "Implemens of hook_install()"
Comment #13
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.